You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/07/07 08:37:11 UTC
[jira] [Commented] (CB-11482) Device-motion
getCurrentAcceleration.accelerometer.spec.5 fails in CI
[ https://issues.apache.org/jira/browse/CB-11482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15365815#comment-15365815 ]
ASF GitHub Bot commented on CB-11482:
-------------------------------------
GitHub user vladimir-kotikov opened a pull request:
https://github.com/apache/cordova-plugin-device-motion/pull/46
CB-11482: (Android) Fix unreliable tests
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist
is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Android
### What does this PR do?
Fixes intermittent tests failures for Android on some devices (mostly on Saucelabs emulators). Also fixes hidden issue on Android when reloading the app would cause Java code stop reporting actual accelerometer values.
### What testing has been done on this change?
Manually ran automated tests. Performed a series of runs on Saucelabs.
### Checklist
- [X] [ICLA](http://www.apache.org/licenses/icla.txt) has been signed and submitted to secretary@apache.org.
- [X] [Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database
- [X] Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
- [ ] Added automated test coverage as appropriate for this change.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vladimir-kotikov/cordova-plugin-device-motion CB-11482
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-device-motion/pull/46.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #46
----
commit 61928a3d9dc5986758bf20856c5e0134291e9903
Author: Vladimir Kotikov <ko...@gmail.com>
Date: 2016-07-07T08:08:42Z
CB-11482 Fix unreliable tests on Android
----
> Device-motion getCurrentAcceleration.accelerometer.spec.5 fails in CI
> ---------------------------------------------------------------------
>
> Key: CB-11482
> URL: https://issues.apache.org/jira/browse/CB-11482
> Project: Apache Cordova
> Issue Type: Bug
> Components: Plugin Device Motion
> Reporter: Sergey Shakhnazarov
> Labels: android, flaky, found-by-ci
>
> cordova-plugin-device-motion-tests.tests >>.Accelerometer (navigator.accelerometer).getCurrentAcceleration.accelerometer.spec.5 success callback Acceleration object should return a recent timestamp
> Error Details
> Expected 1466763450194 to be less than 1466752652197.
> Stack Trace
> Error: Expected 1466763450194 to be less than 1466752652197.
> at stack (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1455:17)
> at buildExpectationResult (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1425:14)
> at Spec.Env.expectationResultFactory (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:572:18)
> at Spec.addExpectationResult (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:321:34)
> at Expectation.addExpectationResult (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:516:21)
> at Expectation.toBeLessThan (file:///android_asset/www/cdvtests/jasmine-2.2.0/jasmine.js:1379:12)
> at win (file:///android_asset/www/plugins/cordova-plugin-device-motion-tests/tests.js:116:31)
> at Object.win (file:///android_asset/www/plugins/cordova-plugin-device-motion/www/accelerometer.js:112:13)
> at file:///android_asset/www/plugins/cordova-plugin-device-motion/www/accelerometer.js:53:30
> at Object.cordova.callbackFromNative (file:///android_asset/www/cordova.js:293:58)
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org