You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/11/16 22:09:21 UTC
[GitHub] [fineract] vorburger opened a new pull request #1485: ContentRepository.fetchImage() FileData not ImageData (FINERACT-1201)
vorburger opened a new pull request #1485:
URL: https://github.com/apache/fineract/pull/1485
This is an extension of #1425 for FINERACT-1201.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1485: ContentRepository.fetchImage() FileData not ImageData (FINERACT-1201)
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1485:
URL: https://github.com/apache/fineract/pull/1485#issuecomment-723344963
> need #1465 here to change it to run against `localhost`. But let's first get #1425 reviewed and merged already.
I'll continue working on this after #1494 is merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger closed pull request #1485: ContentRepository.fetchImage() FileData not ImageData (FINERACT-1201)
Posted by GitBox <gi...@apache.org>.
vorburger closed pull request #1485:
URL: https://github.com/apache/fineract/pull/1485
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] vorburger commented on pull request #1485: ContentRepository.fetchImage() FileData not ImageData (FINERACT-1201)
Posted by GitBox <gi...@apache.org>.
vorburger commented on pull request #1485:
URL: https://github.com/apache/fineract/pull/1485#issuecomment-729214908
@ptuomola @vidakovic @percyashu @xurror @fynmanoj @avikganguly01 @vincent-fuchs @awasum any of you willing to review this, for FINERACT-1201? Once this is in, a few more such refactoring may be proposed, and ultimately I will then work on FINERACT-955 some day.
I'm reasonable confident that this won't break break any :smiling_face_with_three_hearts: the documents and images features, because in FINERACT-1218 I have contributed [new test coverage for all this stuff](https://github.com/apache/fineract/tree/develop/integration-tests/src/test/java/org/apache/fineract/integrationtests/client) (and since FINERACT-1209 those new tests DO actually run in our CI!), but of course careful human code review is always still a good idea... :smiling_imp:
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [fineract] percyashu merged pull request #1485: ContentRepository.fetchImage() FileData not ImageData (FINERACT-1201)
Posted by GitBox <gi...@apache.org>.
percyashu merged pull request #1485:
URL: https://github.com/apache/fineract/pull/1485
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org