You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2019/12/18 15:32:16 UTC
[GitHub] [zookeeper] ztzg opened a new pull request #1186: ZOOKEEPER-3654:
Incorrect *_CFLAGS handling in Automake
ztzg opened a new pull request #1186: ZOOKEEPER-3654: Incorrect *_CFLAGS handling in Automake
URL: https://github.com/apache/zookeeper/pull/1186
The `Makefile.am` distributed with the C client defines some per-target `*_CFLAGS` and `*_CXXFLAGS` variables. These however, do not reference `AM_CFLAGS` (resp. AM_CXXFLAGS`, which means that some options (notably `-Wall`) are missing when building subsets of the code.
Dixit the [Automake docs](https://www.gnu.org/software/automake/manual/html_node/Program-and-Library-Variables.html):
> In compilations with per-target flags, the ordinary ‘AM_’ form of
> the flags variable is _not_ automatically included in the
> compilation (however, the user form of the variable _is_ included).
> So for instance, if you want the hypothetical ‘maude’ compilations
> to also use the value of ‘AM_CFLAGS’, you would need to write:
>
> maude_CFLAGS = ... your flags ... $(AM_CFLAGS)
Restoring the flags, however, causes compilation failures (in the library) and a slew of new warnings (in the tests) which had not been noticed because of the missing options.
This series of patches (all "tagged" ZOOKEEPER-3654) fix these warnings and errors before re-enabling `-Wall` and friends for all targets.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] ztzg commented on issue #1186: ZOOKEEPER-3654:
Incorrect *_CFLAGS handling in Automake
Posted by GitBox <gi...@apache.org>.
ztzg commented on issue #1186: ZOOKEEPER-3654: Incorrect *_CFLAGS handling in Automake
URL: https://github.com/apache/zookeeper/pull/1186#issuecomment-577763816
@eolivelli: There you are :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] ztzg commented on issue #1186: ZOOKEEPER-3654:
Incorrect *_CFLAGS handling in Automake
Posted by GitBox <gi...@apache.org>.
ztzg commented on issue #1186: ZOOKEEPER-3654: Incorrect *_CFLAGS handling in Automake
URL: https://github.com/apache/zookeeper/pull/1186#issuecomment-602637488
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] ztzg commented on issue #1186: ZOOKEEPER-3654:
Incorrect *_CFLAGS handling in Automake
Posted by GitBox <gi...@apache.org>.
ztzg commented on issue #1186: ZOOKEEPER-3654: Incorrect *_CFLAGS handling in Automake
URL: https://github.com/apache/zookeeper/pull/1186#issuecomment-603107252
@eolivelli: It finally went through!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] ztzg commented on issue #1186: ZOOKEEPER-3654:
Incorrect *_CFLAGS handling in Automake
Posted by GitBox <gi...@apache.org>.
ztzg commented on issue #1186: ZOOKEEPER-3654: Incorrect *_CFLAGS handling in Automake
URL: https://github.com/apache/zookeeper/pull/1186#issuecomment-602489242
Hi @eolivelli, @anmolnar,
I have refreshed this series on top of the latest `master`. Could one of you pull this in, as it has the required number of approvals?
Cheers, -D
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] eolivelli closed pull request #1186: ZOOKEEPER-3654:
Incorrect *_CFLAGS handling in Automake
Posted by GitBox <gi...@apache.org>.
eolivelli closed pull request #1186: ZOOKEEPER-3654: Incorrect *_CFLAGS handling in Automake
URL: https://github.com/apache/zookeeper/pull/1186
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #1186: ZOOKEEPER-3654:
Incorrect *_CFLAGS handling in Automake
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #1186: ZOOKEEPER-3654: Incorrect *_CFLAGS handling in Automake
URL: https://github.com/apache/zookeeper/pull/1186#issuecomment-603469171
I will merge as soon as possible.
Sorry for taking so long
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] ztzg commented on issue #1186: ZOOKEEPER-3654:
Incorrect *_CFLAGS handling in Automake
Posted by GitBox <gi...@apache.org>.
ztzg commented on issue #1186: ZOOKEEPER-3654: Incorrect *_CFLAGS handling in Automake
URL: https://github.com/apache/zookeeper/pull/1186#issuecomment-602623087
@eolivelli: Okay, and no problem—but it looks like GitHub and Travis are now conspiring to annoy us :) The status box has been in the "Pending" state for a while, yet following its "Details" link shows that it finished ~1h ago.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] eolivelli commented on issue #1186: ZOOKEEPER-3654:
Incorrect *_CFLAGS handling in Automake
Posted by GitBox <gi...@apache.org>.
eolivelli commented on issue #1186: ZOOKEEPER-3654: Incorrect *_CFLAGS handling in Automake
URL: https://github.com/apache/zookeeper/pull/1186#issuecomment-602577026
Merging as soon as CI ends
Sorry for this taking so long
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [zookeeper] ztzg commented on issue #1186: ZOOKEEPER-3654:
Incorrect *_CFLAGS handling in Automake
Posted by GitBox <gi...@apache.org>.
ztzg commented on issue #1186: ZOOKEEPER-3654: Incorrect *_CFLAGS handling in Automake
URL: https://github.com/apache/zookeeper/pull/1186#issuecomment-603976594
Thank you! (And sorry for the nagging; I understand that you have many other things on your plate!)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services