[GitHub] [airflow] andrewgodwin commented on a change in pull request #19546: Track completed triggers until deleted from database

[GitBox <gi...@apache.org>]

andrewgodwin commented on a change in pull request #19546:
URL: https://github.com/apache/airflow/pull/19546#discussion_r765258471



##########
File path: airflow/jobs/triggerer_job.py
##########
@@ -315,6 +339,7 @@ async def cleanup_finished_triggers(self):
                         details["name"],
                     )
                     self.failed_triggers.append(trigger_id)
+                self.completed_triggers.add(trigger_id)

Review comment:
       I guess I just don't quite trust `difference_update` quite enough, I missed it in my first read-through for "what in here cleans out the datastructure?"
   
   If you're happy there's no edge cases where it can leak entries and write a test to prove so, I think my objection here is void.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org