[jira] [Assigned] (MRESOLVER-339) Preemptive broken when default ports used

["Tamas Cservenak (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/MRESOLVER-339?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Tamas Cservenak reassigned MRESOLVER-339:
-----------------------------------------

    Assignee: Tamas Cservenak

> Preemptive broken when default ports used
> -----------------------------------------
>
>                 Key: MRESOLVER-339
>                 URL: https://issues.apache.org/jira/browse/MRESOLVER-339
>             Project: Maven Resolver
>          Issue Type: Bug
>          Components: Resolver
>    Affects Versions: 1.9.6
>            Reporter: Tamas Cservenak
>            Assignee: Tamas Cservenak
>            Priority: Major
>             Fix For: 1.9.7
>
>
> The feature implemented in MRESOLVER-315 is broken when default HTTP or HTTPS ports (80 or 443 respectively) are used, as in majority of public servers.
> The SharingAuthCache "converts" the HttpHost to port-normalized one, but the code to activate preemptive tampers directly with shared state (not AuthCache), hence in these cases, it is not activated properly due key mismatch. Ironically, as UT does test this feature but are unable to open ports 80 or 443, the feature works ok.
> Fix: migrate to HttpClient 4.3+ HttpClientContext that has type safe setters/getters exposed, and HttpTransport should do things "by the book" (use authCache) that underlying implementation them sorts out proper keying.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)