[jira] Closed: (GERONIMO-607) Logging configuration is unnecessarily processed twice at startup

["Gianny DAMOUR (JIRA)" <de...@geronimo.apache.org>]

     [ http://issues.apache.org/jira/browse/GERONIMO-607?page=history ]
     
Gianny DAMOUR closed GERONIMO-607:
----------------------------------

      Assign To: Gianny DAMOUR
     Resolution: Fixed
    Fix Version: 1.0-M4

Thanks for this patch John.

> Logging configuration is unnecessarily processed twice at startup
> -----------------------------------------------------------------
>
>          Key: GERONIMO-607
>          URL: http://issues.apache.org/jira/browse/GERONIMO-607
>      Project: Geronimo
>         Type: Bug
>     Reporter: John Sisson
>     Assignee: Gianny DAMOUR
>     Priority: Minor
>      Fix For: 1.0-M4
>  Attachments: Log4jService_patch.txt
>
> The following currently occurs when Geronimo is started:
> 1. Geronimo bootstraps logging to the console as part of the static initialisation in the Daemon class.
> 2. The Log4j service GBean org.apache.geronimo.system.logging.log4j.Log4jService's doStart() is called, which in turn calls Log4jService.reconfigure() which in turn causes Log4j's to be configured, therefore opening geronimo.log.  Log4jService.doStart() also starts a timer for monitoring modifications to the log configuration file.
> 3. The timer pops for the first time and since the "lastchanged" variable is -1 the statement at line 411 of Log4jService causes the logging to be reconfigured (log file is closed and reopened) even though the logging configuration wasn't changed:
>                 if (lastChanged < lastModified) {
>                     lastChanged = lastModified;
>                     reconfigure();
>                 }

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira