[jira] [Commented] (BOOKKEEPER-416) LedgerChecker returns underreplicated fragments for an closed ledger with no entries

["Uma Maheswara Rao G (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-416?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13473982#comment-13473982 ] 

Uma Maheswara Rao G commented on BOOKKEEPER-416:
------------------------------------------------

Hi Ivan, Thanks for the patch.

We have one test testShouldNotGetAnyFragmentWithEmptyLedger, it was for open ledger. we missed this case of closed ledger.
Thanks for catching it and fixing.

{code}
       if (curEntryId != null
+            && !(lh.getLastAddConfirmed() == LedgerHandle.INVALID_ENTRY_ID && lh.getLedgerMetadata().isClosed())) {
{code}
Format required, as it is crossing more than 80 chars.

One more comment in tests is that, we need not start the Bookies again once we kill them, as we are not writing or replicating any entries in this cases right.
                
> LedgerChecker returns underreplicated fragments for an closed ledger with no entries
> ------------------------------------------------------------------------------------
>
>                 Key: BOOKKEEPER-416
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-416
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: bookkeeper-auto-recovery
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 4.2.0
>
>         Attachments: BOOKKEEPER-416.diff
>
>
> It should return no underreplicated fragments. This causes a problem because as it can never become "fully replicated" as there are no entries to replicate, everything hangs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira