svn commit: r1128230 - in /subversion/trunk/subversion/libsvn_ra_serf: ra_serf.h util.c

[gs...@apache.org]

Author: gstein
Date: Fri May 27 10:01:38 2011
New Revision: 1128230

URL: http://svn.apache.org/viewvc?rev=1128230&view=rev
Log:
Nobody ever used the return value of svn_ra_serf__request_create(), so
just formalize that by "returning" void.

* subversion/libsvn_ra_serf/util.c:
  (svn_ra_serf__request_create): switch to (void) return. add comment.

* subversion/libsvn_ra_serf/ra_serf.h:
  (svn_ra_serf__request_create): switch to (void) return.

Modified:
    subversion/trunk/subversion/libsvn_ra_serf/ra_serf.h
    subversion/trunk/subversion/libsvn_ra_serf/util.c

Modified: subversion/trunk/subversion/libsvn_ra_serf/ra_serf.h
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/ra_serf.h?rev=1128230&r1=1128229&r2=1128230&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/ra_serf.h (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/ra_serf.h Fri May 27 10:01:38 2011
@@ -473,8 +473,7 @@ typedef struct svn_ra_serf__handler_t {
 /*
  * Helper function to queue a request in the @a handler's connection.
  */
-serf_request_t*
-svn_ra_serf__request_create(svn_ra_serf__handler_t *handler);
+void svn_ra_serf__request_create(svn_ra_serf__handler_t *handler);
 
 /* XML helper callbacks. */
 

Modified: subversion/trunk/subversion/libsvn_ra_serf/util.c
URL: http://svn.apache.org/viewvc/subversion/trunk/subversion/libsvn_ra_serf/util.c?rev=1128230&r1=1128229&r2=1128230&view=diff
==============================================================================
--- subversion/trunk/subversion/libsvn_ra_serf/util.c (original)
+++ subversion/trunk/subversion/libsvn_ra_serf/util.c Fri May 27 10:01:38 2011
@@ -1638,10 +1638,12 @@ setup_request_cb(serf_request_t *request
   return APR_SUCCESS;
 }
 
-serf_request_t *
+void
 svn_ra_serf__request_create(svn_ra_serf__handler_t *handler)
 {
-  return serf_connection_request_create(handler->conn->conn,
+  /* ### do we need to hold onto the returned request object, or just
+     ### not worry about it (the serf ctx will manage it).  */
+  (void) serf_connection_request_create(handler->conn->conn,
                                         setup_request_cb, handler);
 }