[GitHub] [airflow] potiuk commented on a change in pull request #5162: [AIRFLOW-4358] Speed up test_jobs by not running tasks

[GitBox <gi...@apache.org>]

potiuk commented on a change in pull request #5162: [AIRFLOW-4358] Speed up test_jobs by not running tasks
URL: https://github.com/apache/airflow/pull/5162#discussion_r279487876
 
 

 ##########
 File path: tests/executors/test_executor.py
 ##########
 @@ -16,47 +16,73 @@
 # KIND, either express or implied.  See the License for the
 # specific language governing permissions and limitations
 # under the License.
+
+from collections import defaultdict
+
 from airflow.executors.base_executor import BaseExecutor
 from airflow.utils.state import State
-
-from airflow import settings
+from airflow.utils.db import create_session
 
 
 class TestExecutor(BaseExecutor):
     """
     TestExecutor is used for unit testing purposes.
     """
 
-    def __init__(self, do_update=False, *args, **kwargs):
+    def __init__(self, do_update=True, *args, **kwargs):
         self.do_update = do_update
         self._running = []
+
+        # A list of "batches" of tasks
         self.history = []
+        # All the tasks, in a stable sort order
+        self.sorted_tasks = []
+        self.mock_task_results = defaultdict(lambda: State.SUCCESS)
 
         super().__init__(*args, **kwargs)
 
-    def execute_async(self, key, command, queue=None):
-        self.log.debug("{} running task instances".format(len(self.running)))
-        self.log.debug("{} in queue".format(len(self.queued_tasks)))
-
     def heartbeat(self):
-        session = settings.Session()
-        if self.do_update:
+        if not self.do_update:
 
 Review comment:
   I think it's easier to do it via the constructor. There is no direct added benefit of using mock in this case especially that this is purely Test-specific class so we can implement it's behaviour as we want rather than mock it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services