You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/10/21 07:35:43 UTC

[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #1728: [Enhancement] Inefficient use of keyset iterator instead of entrySet iterator [LocalSubscribeEventProcessor]

Alonexc opened a new issue, #1728:
URL: https://github.com/apache/incubator-eventmesh/issues/1728

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
   
   
   ### Enhancement Request
   
   ![image](https://user-images.githubusercontent.com/91315508/197139395-9fee421e-c40a-41c9-af6a-adaf222e73ea.png)
   located at:
   org/apache/eventmesh/runtime/core/protocol/http/processor/LocalSubscribeEventProcessor.java 244
   analysis and explanation:
   This method accesses the value of a Map entry, using a key that was retrieved from a keySet iterator. It is more efficient to use an iterator on the entrySet of the map, to avoid the Map.get(key) lookup.
   
   ### Describe the solution you'd like
   
   reference:
   ![image](https://user-images.githubusercontent.com/91315508/197139442-0599989f-cad6-4888-a47e-73f3b5ebbdaf.png)
   
   
   ### Are you willing to submit PR?
   
   - [ ] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] NewtonVan commented on issue #1728: [Enhancement] Inefficient use of keyset iterator instead of entrySet iterator [LocalSubscribeEventProcessor]

Posted by GitBox <gi...@apache.org>.
NewtonVan commented on issue #1728:
URL: https://github.com/apache/incubator-eventmesh/issues/1728#issuecomment-1287592109

   @xwm1992 Hi, I'm a newbie on eventmesh and I think I'm capable of fixing this issue. Would u pls assign this to me?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] xwm1992 closed issue #1728: [Enhancement] Inefficient use of keyset iterator instead of entrySet iterator [LocalSubscribeEventProcessor]

Posted by GitBox <gi...@apache.org>.
xwm1992 closed issue #1728: [Enhancement] Inefficient use of keyset iterator instead of entrySet iterator [LocalSubscribeEventProcessor]
URL: https://github.com/apache/incubator-eventmesh/issues/1728


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org


[GitHub] [incubator-eventmesh] Pragalapavithra23 commented on issue #1728: [Enhancement] Inefficient use of keyset iterator instead of entrySet iterator [LocalSubscribeEventProcessor]

Posted by GitBox <gi...@apache.org>.
Pragalapavithra23 commented on issue #1728:
URL: https://github.com/apache/incubator-eventmesh/issues/1728#issuecomment-1287099601

   @xwm1992 I can work on this , can you pls assign it to my name 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org