You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/02/06 02:45:40 UTC

[GitHub] [kafka] C0urante opened a new pull request #10073: KAFKA-12303: Fix handling of null values by Flatten SMT

C0urante opened a new pull request #10073:
URL: https://github.com/apache/kafka/pull/10073


   [Jira](https://issues.apache.org/jira/browse/KAFKA-12303)
   
   Using `return` instead of `continue` when encountering null fields causes the remainder of the fields to be skipped. This PR addresses that, and adds a lightweight unit test that is able to reproduce the error on current versions of Connect, and verify the accuracy of the fix.
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] mimaison merged pull request #10073: KAFKA-12303: Fix handling of null values by Flatten SMT

Posted by GitBox <gi...@apache.org>.
mimaison merged pull request #10073:
URL: https://github.com/apache/kafka/pull/10073


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] C0urante commented on pull request #10073: KAFKA-12303: Fix handling of null values by Flatten SMT

Posted by GitBox <gi...@apache.org>.
C0urante commented on pull request #10073:
URL: https://github.com/apache/kafka/pull/10073#issuecomment-781425022


   Thanks Mickael!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] C0urante commented on pull request #10073: KAFKA-12303: Fix handling of null values by Flatten SMT

Posted by GitBox <gi...@apache.org>.
C0urante commented on pull request #10073:
URL: https://github.com/apache/kafka/pull/10073#issuecomment-779866596


   @gharris1727 @ncliang @tombentley anyone got time to take a look?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org