[GitHub] [lucene-solr] euske opened a new pull request #961: [LUCENE-9019] Patch for making some variable names more consistent with the other parts of the code.

[GitBox <gi...@apache.org>]

euske opened a new pull request #961: [LUCENE-9019] Patch for making some variable names more consistent with the other parts of the code.
URL: https://github.com/apache/lucene-solr/pull/961
 
 
   [LUCENE-9019] Patch for making some variable names more consistent with the other parts of the code.
   
   Hello, we're developing an automated system that detects inconsistent variable names in a large software project. Our system checks if each variable name is consistent with other variables in the project in its usage pattern, and proposes correct candidates if inconsistency is detected. This is a part of academic research that we hope to publish soon, but as a part of the evaluation, we applied our systems to your projects and got a few interesting results. We carefully reviewed our system output and manually created a patch to correct a few variable names. We would be delighted if this patch is found to be useful. If you have a question or suggestion regarding this patch, we'd happily
   answer. Thank you.
   
   P.S. our patch is purely for readability purposes and does not change any functionality. A couple of issues that we've noticed were left untouched. For example, mixed use of variable names "len" and "length" were fairly widespread, but we have only corrected a few notable instances to minimize our impact.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org