You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by John Sirois <js...@apache.org> on 2016/04/13 07:09:56 UTC
Re: Review Request 45298: Remove some dependencies linked to docker
usage
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45298/#review128611
-----------------------------------------------------------
Pierre - do you want to continue with this RB and finisg up the doc fix?
- John Sirois
On March 24, 2016, 12:04 p.m., Pierre Cheynier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45298/
> -----------------------------------------------------------
>
> (Updated March 24, 2016, 12:04 p.m.)
>
>
> Review request for Aurora and John Sirois.
>
>
> Repository: aurora-packaging
>
>
> Description
> -------
>
> An operator should be able to build Aurora on his platform without
> relying on Docker.
>
> Even if this is an interesting way of doing it, it sometimes introduce missed
> (build-)dependencies (in this case openssl) and context-specific behaviour
> (here, the way pants.ini was added to the build context)
>
>
> Diffs
> -----
>
> README.md 3a7cf45034b7896c23588fed83176468ca627ebc
> builder/deb/debian-jessie/Dockerfile 63e89deed9a411b1859ba28ea2572ef4a210da1f
> builder/deb/debian-jessie/pants.ini 2ff2d5eb6128d4be3e15c0488d8d23bed81a8d5b
> builder/deb/ubuntu-trusty/Dockerfile 52739100c9593292a7aea2459412c8e49f0155a4
> builder/deb/ubuntu-trusty/pants.ini
> builder/rpm/centos-7/Dockerfile a4d9dfcee5637d23333c31d0c2b63a9ebcf04e8d
> builder/rpm/centos-7/pants.ini
> specs/debian/control a30e987e4423c611c86518a8f5e3e68ee996982a
> specs/debian/rules 974fddfda6da04686daae691fa32c5b4c11a0b5d
> specs/rpm/aurora.spec 61e7d146108ae7dd5e129d8288a05773c2659d25
>
> Diff: https://reviews.apache.org/r/45298/diff/
>
>
> Testing
> -------
>
> Able to build on CentOS 6 using mock.
> Able to build on Debian. Limitation = need the patched version of Gradle.
> Still able to build using the current Docker build system
>
>
> Thanks,
>
> Pierre Cheynier
>
>
Re: Review Request 45298: Remove some dependencies linked to docker
usage
Posted by Pierre Cheynier <me...@pierre-cheynier.net>.
> On April 13, 2016, 5:09 a.m., John Sirois wrote:
> > Pierre - do you want to continue with this RB and finisg up the doc fix?
Hi John.
I'm sorry about all my reviews, I had (and still have) not enough time to answer and complete them.
Here is a fix, I replaced the source from github to apache, we don't have to fix the doc anymore.
- Pierre
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45298/#review128611
-----------------------------------------------------------
On April 13, 2016, 10:47 a.m., Pierre Cheynier wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45298/
> -----------------------------------------------------------
>
> (Updated April 13, 2016, 10:47 a.m.)
>
>
> Review request for Aurora and John Sirois.
>
>
> Repository: aurora-packaging
>
>
> Description
> -------
>
> An operator should be able to build Aurora on his platform without
> relying on Docker.
>
> Even if this is an interesting way of doing it, it sometimes introduce missed
> (build-)dependencies (in this case openssl) and context-specific behaviour
> (here, the way pants.ini was added to the build context)
>
>
> Diffs
> -----
>
> builder/deb/debian-jessie/Dockerfile 63e89deed9a411b1859ba28ea2572ef4a210da1f
> builder/deb/debian-jessie/pants.ini 2ff2d5eb6128d4be3e15c0488d8d23bed81a8d5b
> builder/deb/ubuntu-trusty/Dockerfile 52739100c9593292a7aea2459412c8e49f0155a4
> builder/deb/ubuntu-trusty/pants.ini
> builder/rpm/centos-7/Dockerfile a4d9dfcee5637d23333c31d0c2b63a9ebcf04e8d
> builder/rpm/centos-7/pants.ini
> specs/debian/control a30e987e4423c611c86518a8f5e3e68ee996982a
> specs/debian/rules 974fddfda6da04686daae691fa32c5b4c11a0b5d
> specs/rpm/aurora.spec 61e7d146108ae7dd5e129d8288a05773c2659d25
>
> Diff: https://reviews.apache.org/r/45298/diff/
>
>
> Testing
> -------
>
> Able to build on CentOS 6 using mock.
> Able to build on Debian. Limitation = need the patched version of Gradle.
> Still able to build using the current Docker build system
>
>
> Thanks,
>
> Pierre Cheynier
>
>