You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "jacktengg (via GitHub)" <gi...@apache.org> on 2023/03/06 08:43:32 UTC

[GitHub] [doris] jacktengg opened a new pull request, #17456: [fix](bitmap) fix wrong result of bitmap_or for null

jacktengg opened a new pull request, #17456:
URL: https://github.com/apache/doris/pull/17456

   # Proposed changes
   
   Issue Number: close #xxx
   
   ## Problem summary
   
   Result of `select bitmap_to_string(bitmap_or(to_bitmap(1), null))` should be `1` instead `of null`.
   
   ## Checklist(Required)
   
   * [ ] Does it affect the original behavior
   * [ ] Has unit tests been added
   * [ ] Has document been added or modified
   * [ ] Does it need to update dependencies
   * [ ] Is this PR support rollback (If NO, please explain WHY)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] yiguolei merged pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "yiguolei (via GitHub)" <gi...@apache.org>.
yiguolei merged PR #17456:
URL: https://github.com/apache/doris/pull/17456


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jacktengg commented on pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #17456:
URL: https://github.com/apache/doris/pull/17456#issuecomment-1457936637

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jacktengg commented on pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #17456:
URL: https://github.com/apache/doris/pull/17456#issuecomment-1456393271

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17456:
URL: https://github.com/apache/doris/pull/17456#issuecomment-1459536121

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17456:
URL: https://github.com/apache/doris/pull/17456#issuecomment-1459643212

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17456:
URL: https://github.com/apache/doris/pull/17456#issuecomment-1456390775

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17456:
URL: https://github.com/apache/doris/pull/17456#issuecomment-1455722307

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jacktengg commented on pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #17456:
URL: https://github.com/apache/doris/pull/17456#issuecomment-1457622855

   run p0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jacktengg commented on pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #17456:
URL: https://github.com/apache/doris/pull/17456#issuecomment-1457699610

   run clickbench


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17456:
URL: https://github.com/apache/doris/pull/17456#issuecomment-1457919122

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] HappenLee commented on a diff in pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #17456:
URL: https://github.com/apache/doris/pull/17456#discussion_r1128930931


##########
be/src/vec/functions/function_bitmap_variadic.cpp:
##########
@@ -54,18 +96,39 @@ namespace doris::vectorized {
         using TData = std::vector<BitmapValue>;                                                    \
         using ResTData = typename ColumnVector<Int64>::Container;                                  \
         static Status vector_vector(ColumnPtr argument_columns[], size_t col_size,                 \
-                                    size_t input_rows_count, ResTData& res) {                      \
-            TData vals = assert_cast<const ColumnBitmap*>(argument_columns[0].get())->get_data();  \
+                                    size_t input_rows_count, ResTData& res, IColumn* res_nulls) {  \
+            TData vals;                                                                            \
+            if (auto* nullable = check_and_get_column<ColumnNullable>(*argument_columns[0])) {     \
+                const auto& nested_col_ptr = nullable->get_nested_column_ptr();                    \
+                vals = assert_cast<const ColumnBitmap*>(nested_col_ptr.get())->get_data();         \
+            } else {                                                                               \
+                vals = assert_cast<const ColumnBitmap*>(argument_columns[0].get())->get_data();    \
+            }                                                                                      \
             for (size_t col = 1; col < col_size; ++col) {                                          \
-                auto& col_data =                                                                   \
-                        assert_cast<const ColumnBitmap*>(argument_columns[col].get())->get_data(); \
+                const ColumnBitmap::Container* col_data_ptr;                                       \
+                if (auto* nullable =                                                               \
+                            check_and_get_column<ColumnNullable>(*argument_columns[col])) {        \
+                    const auto& nested_col_ptr = nullable->get_nested_column_ptr();                \
+                    col_data_ptr =                                                                 \
+                            &(assert_cast<const ColumnBitmap*>(nested_col_ptr.get())->get_data()); \
+                } else {                                                                           \
+                    col_data_ptr = &(assert_cast<const ColumnBitmap*>(argument_columns[col].get()) \
+                                             ->get_data());                                        \
+                }                                                                                  \
+                const auto& col_data = *col_data_ptr;                                              \
                 for (size_t row = 0; row < input_rows_count; ++row) {                              \
                     vals[row] OP col_data[row];                                                    \
                 }                                                                                  \
             }                                                                                      \
             for (size_t row = 0; row < input_rows_count; ++row) {                                  \
                 res[row] = vals[row].cardinality();                                                \
             }                                                                                      \
+            if (res_nulls) {                                                                       \

Review Comment:
   delete the code. better init the ColumnUInt8 by constructor



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jacktengg commented on pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #17456:
URL: https://github.com/apache/doris/pull/17456#issuecomment-1457679044

   run feut


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jacktengg commented on pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #17456:
URL: https://github.com/apache/doris/pull/17456#issuecomment-1458037237

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17456:
URL: https://github.com/apache/doris/pull/17456#issuecomment-1456558193

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jacktengg commented on pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #17456:
URL: https://github.com/apache/doris/pull/17456#issuecomment-1456524439

   run feut


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] HappenLee commented on a diff in pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #17456:
URL: https://github.com/apache/doris/pull/17456#discussion_r1127528250


##########
gensrc/script/doris_builtins_functions.py:
##########
@@ -1407,8 +1407,8 @@
     [['bitmap_count'], 'BIGINT', ['BITMAP'], 'ALWAYS_NOT_NULLABLE'],
     [['bitmap_and_not_count'], 'BIGINT', ['BITMAP','BITMAP'], ''],
     [['bitmap_empty'], 'BITMAP', [], 'ALWAYS_NOT_NULLABLE'],
-    [['bitmap_or'], 'BITMAP', ['BITMAP','BITMAP','...'], ''],
-    [['bitmap_or'], 'BITMAP', ['BITMAP','BITMAP'], ''],
+    [['bitmap_or'], 'BITMAP', ['BITMAP','BITMAP','...'], 'CUSTOM'],

Review Comment:
   change a function nullable way may cause coredump in update 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17456:
URL: https://github.com/apache/doris/pull/17456#issuecomment-1456384618

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jacktengg commented on a diff in pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on code in PR #17456:
URL: https://github.com/apache/doris/pull/17456#discussion_r1127651912


##########
gensrc/script/doris_builtins_functions.py:
##########
@@ -1407,8 +1407,8 @@
     [['bitmap_count'], 'BIGINT', ['BITMAP'], 'ALWAYS_NOT_NULLABLE'],
     [['bitmap_and_not_count'], 'BIGINT', ['BITMAP','BITMAP'], ''],
     [['bitmap_empty'], 'BITMAP', [], 'ALWAYS_NOT_NULLABLE'],
-    [['bitmap_or'], 'BITMAP', ['BITMAP','BITMAP','...'], ''],
-    [['bitmap_or'], 'BITMAP', ['BITMAP','BITMAP'], ''],
+    [['bitmap_or'], 'BITMAP', ['BITMAP','BITMAP','...'], 'CUSTOM'],

Review Comment:
   fixed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17456:
URL: https://github.com/apache/doris/pull/17456#issuecomment-1456270614

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jacktengg commented on pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #17456:
URL: https://github.com/apache/doris/pull/17456#issuecomment-1458550682

   run p0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jacktengg commented on pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #17456:
URL: https://github.com/apache/doris/pull/17456#issuecomment-1456557151

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jacktengg commented on pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #17456:
URL: https://github.com/apache/doris/pull/17456#issuecomment-1457426720

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17456:
URL: https://github.com/apache/doris/pull/17456#issuecomment-1459528902

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jacktengg commented on pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #17456:
URL: https://github.com/apache/doris/pull/17456#issuecomment-1457678926

   run beut


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jacktengg commented on pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #17456:
URL: https://github.com/apache/doris/pull/17456#issuecomment-1457484198

   run feut


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17456:
URL: https://github.com/apache/doris/pull/17456#issuecomment-1459643260

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17456:
URL: https://github.com/apache/doris/pull/17456#issuecomment-1458026754

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] HappenLee commented on a diff in pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #17456:
URL: https://github.com/apache/doris/pull/17456#discussion_r1128929961


##########
be/src/vec/functions/function_bitmap_variadic.cpp:
##########
@@ -54,18 +96,39 @@ namespace doris::vectorized {
         using TData = std::vector<BitmapValue>;                                                    \
         using ResTData = typename ColumnVector<Int64>::Container;                                  \
         static Status vector_vector(ColumnPtr argument_columns[], size_t col_size,                 \
-                                    size_t input_rows_count, ResTData& res) {                      \
-            TData vals = assert_cast<const ColumnBitmap*>(argument_columns[0].get())->get_data();  \
+                                    size_t input_rows_count, ResTData& res, IColumn* res_nulls) {  \
+            TData vals;                                                                            \
+            if (auto* nullable = check_and_get_column<ColumnNullable>(*argument_columns[0])) {     \
+                const auto& nested_col_ptr = nullable->get_nested_column_ptr();                    \
+                vals = assert_cast<const ColumnBitmap*>(nested_col_ptr.get())->get_data();         \
+            } else {                                                                               \
+                vals = assert_cast<const ColumnBitmap*>(argument_columns[0].get())->get_data();    \
+            }                                                                                      \
             for (size_t col = 1; col < col_size; ++col) {                                          \
-                auto& col_data =                                                                   \
-                        assert_cast<const ColumnBitmap*>(argument_columns[col].get())->get_data(); \
+                const ColumnBitmap::Container* col_data_ptr;                                       \
+                if (auto* nullable =                                                               \
+                            check_and_get_column<ColumnNullable>(*argument_columns[col])) {        \
+                    const auto& nested_col_ptr = nullable->get_nested_column_ptr();                \
+                    col_data_ptr =                                                                 \
+                            &(assert_cast<const ColumnBitmap*>(nested_col_ptr.get())->get_data()); \
+                } else {                                                                           \
+                    col_data_ptr = &(assert_cast<const ColumnBitmap*>(argument_columns[col].get()) \
+                                             ->get_data());                                        \
+                }                                                                                  \
+                const auto& col_data = *col_data_ptr;                                              \
                 for (size_t row = 0; row < input_rows_count; ++row) {                              \
                     vals[row] OP col_data[row];                                                    \
                 }                                                                                  \
             }                                                                                      \
             for (size_t row = 0; row < input_rows_count; ++row) {                                  \
                 res[row] = vals[row].cardinality();                                                \
             }                                                                                      \
+            if (res_nulls) {                                                                       \

Review Comment:
   delete the code. better init the ColumnUInt8 by constructor



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jacktengg commented on pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #17456:
URL: https://github.com/apache/doris/pull/17456#issuecomment-1459535807

   run buildall 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17456:
URL: https://github.com/apache/doris/pull/17456#issuecomment-1457626271

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #17456:
URL: https://github.com/apache/doris/pull/17456#issuecomment-1457424184

   clang-tidy review says "All clean, LGTM! :+1:"


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jacktengg commented on pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #17456:
URL: https://github.com/apache/doris/pull/17456#issuecomment-1457478485

   run feut


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jacktengg commented on pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #17456:
URL: https://github.com/apache/doris/pull/17456#issuecomment-1457332155

   run p0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] jacktengg commented on pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "jacktengg (via GitHub)" <gi...@apache.org>.
jacktengg commented on PR #17456:
URL: https://github.com/apache/doris/pull/17456#issuecomment-1456380824

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] HappenLee commented on a diff in pull request #17456: [fix](bitmap) fix wrong result of bitmap_or for null

Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #17456:
URL: https://github.com/apache/doris/pull/17456#discussion_r1128929456


##########
be/src/vec/functions/function_bitmap_variadic.cpp:
##########
@@ -113,13 +197,27 @@ class FunctionBitMapVariadic : public IFunction {
                 std::conditional_t<is_complex_v<ResultType>, ColumnComplexType<ResultType>,
                                    ColumnVector<ResultType>>;
         typename ColVecResult::MutablePtr col_res = nullptr;
+
+        typename ColumnUInt8::MutablePtr col_res_nulls;
+        auto& result_info = block.get_by_position(result);
+        // special case for bitmap_or and bitmap_or_count
+        if (!use_default_implementation_for_nulls() && result_info.type->is_nullable()) {
+            col_res_nulls = ColumnUInt8::create(input_rows_count);

Review Comment:
   ```col_res_nulls = ColumnUInt8::create(input_rows_count, false);```
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org