You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/09/17 09:47:58 UTC
[GitHub] [zookeeper] TisonKun opened a new pull request #1459: hotfix: correct junit test timeout
TisonKun opened a new pull request #1459:
URL: https://github.com/apache/zookeeper/pull/1459
@LiYvbo @eolivelli
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on pull request #1459: ZOOKEEPER-3863: correct junit test timeout
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1459:
URL: https://github.com/apache/zookeeper/pull/1459#issuecomment-694176700
```
sing credential 683f5dcf-5552-4b28-9fb1-6a6b77cf53dd
Cloning the remote Git repository
Cloning with configured refspecs honoured and without tags
Cloning repository https://github.com/apache/zookeeper.git
> git init /home/jenkins/jenkins-home/workspace/eper-precommit-github-pr_PR-1459 # timeout=10
Fetching upstream changes from https://github.com/apache/zookeeper.git
> git --version # timeout=10
using GIT_ASKPASS to set credentials ASF Cloudbees Jenkins ci-hadoop
> git fetch --no-tags --progress -- https://github.com/apache/zookeeper.git +refs/pull/1459/head:refs/remotes/origin/PR-1459 +refs/heads/master:refs/remotes/origin/master # timeout=10
> git config remote.origin.url https://github.com/apache/zookeeper.git # timeout=10
> git config --add remote.origin.fetch +refs/pull/1459/head:refs/remotes/origin/PR-1459 # timeout=10
> git config --add remote.origin.fetch +refs/heads/master:refs/remotes/origin/master # timeout=10
Fetching without tags
Merging remotes/origin/master commit c47ef905e077184bc5b7f555a3e2dfeb6dc046e1 into PR head commit d33e75c97b0bf6729f4c3a67416f1a201ad31824
Merge succeeded, producing d33e75c97b0bf6729f4c3a67416f1a201ad31824
Checking out Revision d33e75c97b0bf6729f4c3a67416f1a201ad31824 (PR-1459)
> git config remote.origin.url https://github.com/apache/zookeeper.git # timeout=10
Fetching upstream changes from https://github.com/apache/zookeeper.git
using GIT_ASKPASS to set credentials ASF Cloudbees Jenkins ci-hadoop
> git fetch --no-tags --progress -- https://github.com/apache/zookeeper.git +refs/pull/1459/head:refs/remotes/origin/PR-1459 +refs/heads/master:refs/remotes/origin/master # timeout=10
> git config core.sparsecheckout # timeout=10
> git checkout -f d33e75c97b0bf6729f4c3a67416f1a201ad31824 # timeout=10
> git merge c47ef905e077184bc5b7f555a3e2dfeb6dc046e1 # timeout=10
> git rev-parse HEAD^{commit} # timeout=10
> git config core.sparsecheckout # timeout=10
> git checkout -f d33e75c97b0bf6729f4c3a67416f1a201ad31824 # timeout=10
Commit message: "ZOOKEEPER-3863: correct junit test timeout"
> git rev-list --no-walk d33e75c97b0bf6729f4c3a67416f1a201ad31824 # timeout=10
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] TisonKun edited a comment on pull request #1459: hotfix: correct junit test timeout
Posted by GitBox <gi...@apache.org>.
TisonKun edited a comment on pull request #1459:
URL: https://github.com/apache/zookeeper/pull/1459#issuecomment-694123586
I'm not sure whether we have to file an issue. If so I'm ok to file one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] TisonKun commented on pull request #1459: hotfix: correct junit test timeout
Posted by GitBox <gi...@apache.org>.
TisonKun commented on pull request #1459:
URL: https://github.com/apache/zookeeper/pull/1459#issuecomment-694152863
> @TisonKun thanks for pointing this out
> but the build fails with your patch
>
> ```
>
> [2020-09-17T09:49:01.077Z] [INFO] Finished at: 2020-09-17T09:49:00Z
>
> [2020-09-17T09:49:01.077Z] [INFO] ------------------------------------------------------------------------
>
> [2020-09-17T09:49:01.077Z] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile (default-testCompile) on project zookeeper: Compilation failure
>
> [2020-09-17T09:49:01.077Z] [ERROR] /home/jenkins/jenkins-home/workspace/eper-precommit-github-pr_PR-1459/zookeeper-server/src/test/java/org/apache/zookeeper/test/ReadOnlyModeTest.java:[248,21] cannot find symbol
>
> [2020-09-17T09:49:01.077Z] [ERROR] symbol: method timeout()
>
> [2020-09-17T09:49:01.077Z] [ERROR] location: @interface org.junit.jupiter.api.Test
>
> [2020-09-17T09:49:01.077Z] [ERROR]
>
> [2020-09-17T09:49:01.077Z] [ERROR] -> [Help 1]
> ```
The patch is just fix this issue. Did pr-merge run with previous version? Locally verified and it seems Travis gave green.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on pull request #1459: ZOOKEEPER-3863: correct junit test timeout
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1459:
URL: https://github.com/apache/zookeeper/pull/1459#issuecomment-694179507
Yes,
here it is a proposal of fix
https://github.com/apache/zookeeper/pull/1460
I have sent an email message to dev@zookeeper.apache.org
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on pull request #1459: ZOOKEEPER-3863: correct junit test timeout
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1459:
URL: https://github.com/apache/zookeeper/pull/1459#issuecomment-694176372
Locally master branch wasn't able to compile.
I have merged this patch, no more issues.
It is very weird that it looks like Jenkins didn't build the PR but the master branch
@anmolnar do you have any clue ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli closed pull request #1459: ZOOKEEPER-3863: correct junit test timeout
Posted by GitBox <gi...@apache.org>.
eolivelli closed pull request #1459:
URL: https://github.com/apache/zookeeper/pull/1459
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on pull request #1459: ZOOKEEPER-3863: correct junit test timeout
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1459:
URL: https://github.com/apache/zookeeper/pull/1459#issuecomment-694173160
@TisonKun I have restarted the build
https://ci-hadoop.apache.org/blue/organizations/jenkins/zookeeper-precommit-github-pr/detail/PR-1459/3/pipeline
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] TisonKun commented on pull request #1459: hotfix: correct junit test timeout
Posted by GitBox <gi...@apache.org>.
TisonKun commented on pull request #1459:
URL: https://github.com/apache/zookeeper/pull/1459#issuecomment-694123586
I'm not sure whether we have to file an issue. If so I'd like to file one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] LiYvbo commented on pull request #1459: ZOOKEEPER-3863: correct junit test timeout
Posted by GitBox <gi...@apache.org>.
LiYvbo commented on pull request #1459:
URL: https://github.com/apache/zookeeper/pull/1459#issuecomment-694178364
> Then jenkins checks out again current master !
>
> ```
>
> [2020-09-17T11:36:02.742Z] No credentials specified
>
> [2020-09-17T11:36:02.816Z] Fetching changes from the remote Git repository
>
> [2020-09-17T11:36:02.805Z] > git rev-parse --is-inside-work-tree # timeout=10
>
> [2020-09-17T11:36:02.879Z] > git config remote.origin.url https://github.com/apache/zookeeper # timeout=10
>
> [2020-09-17T11:36:02.953Z] Fetching upstream changes from https://github.com/apache/zookeeper
>
> [2020-09-17T11:36:02.953Z] > git --version # timeout=10
>
> [2020-09-17T11:36:02.957Z] > git fetch --tags --progress -- https://github.com/apache/zookeeper +refs/heads/*:refs/remotes/origin/* # timeout=10
>
> [2020-09-17T11:36:10.782Z] > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
>
> [2020-09-17T11:36:10.870Z] Checking out Revision c47ef905e077184bc5b7f555a3e2dfeb6dc046e1 (refs/remotes/origin/master)
>
> [2020-09-17T11:36:11.158Z] Commit message: "ZOOKEEPER-3863: Do not track global sessions in ReadOnlyZooKeeperServer"
>
> [2020-09-17T11:36:10.856Z] > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
>
> [2020-09-17T11:36:10.999Z] > git config core.sparsecheckout # timeout=10
>
> [2020-09-17T11:36:11.003Z] > git checkout -f c47ef905e077184bc5b7f555a3e2dfeb6dc046e1 # timeout=10
>
> [2020-09-17T11:36:11.033Z] > git branch -a -v --no-abbrev # timeout=10
>
> [2020-09-17T11:36:11.044Z] > git checkout -b master c47ef905e077184bc5b7f555a3e2dfeb6dc046e1 # timeout=10
>
> [2020-09-17T11:36:11.221Z] > git rev-list --no-walk c47ef905e077184bc5b7f555a3e2dfeb6dc046e1 # timeout=10
> ```
can you please restart CI check for me in this PR? The failure was caused by the same reason..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] LiYvbo commented on pull request #1459: ZOOKEEPER-3863: correct junit test timeout
Posted by GitBox <gi...@apache.org>.
LiYvbo commented on pull request #1459:
URL: https://github.com/apache/zookeeper/pull/1459#issuecomment-694191416
> Yes,
> here it is a proposal of fix
> #1460
>
> I have sent an email message to [dev@zookeeper.apache.org](mailto:dev@zookeeper.apache.org)
Thanks! @eolivelli
After building, please make a review for PR https://github.com/apache/zookeeper/pull/1458. It is the same with PR https://github.com/apache/zookeeper/pull/1454. I add a Jira for this PR1458 to track the improvement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] TisonKun commented on pull request #1459: hotfix: correct junit test timeout
Posted by GitBox <gi...@apache.org>.
TisonKun commented on pull request #1459:
URL: https://github.com/apache/zookeeper/pull/1459#issuecomment-694152987
> can you please include the original JIRA id in the commit message ?
> this is part of the same issue
ok
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on pull request #1459: ZOOKEEPER-3863: correct junit test timeout
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1459:
URL: https://github.com/apache/zookeeper/pull/1459#issuecomment-694177145
Then jenkins checks out again current master !
```
[2020-09-17T11:36:02.742Z] No credentials specified
[2020-09-17T11:36:02.816Z] Fetching changes from the remote Git repository
[2020-09-17T11:36:02.805Z] > git rev-parse --is-inside-work-tree # timeout=10
[2020-09-17T11:36:02.879Z] > git config remote.origin.url https://github.com/apache/zookeeper # timeout=10
[2020-09-17T11:36:02.953Z] Fetching upstream changes from https://github.com/apache/zookeeper
[2020-09-17T11:36:02.953Z] > git --version # timeout=10
[2020-09-17T11:36:02.957Z] > git fetch --tags --progress -- https://github.com/apache/zookeeper +refs/heads/*:refs/remotes/origin/* # timeout=10
[2020-09-17T11:36:10.782Z] > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
[2020-09-17T11:36:10.870Z] Checking out Revision c47ef905e077184bc5b7f555a3e2dfeb6dc046e1 (refs/remotes/origin/master)
[2020-09-17T11:36:11.158Z] Commit message: "ZOOKEEPER-3863: Do not track global sessions in ReadOnlyZooKeeperServer"
[2020-09-17T11:36:10.856Z] > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
[2020-09-17T11:36:10.999Z] > git config core.sparsecheckout # timeout=10
[2020-09-17T11:36:11.003Z] > git checkout -f c47ef905e077184bc5b7f555a3e2dfeb6dc046e1 # timeout=10
[2020-09-17T11:36:11.033Z] > git branch -a -v --no-abbrev # timeout=10
[2020-09-17T11:36:11.044Z] > git checkout -b master c47ef905e077184bc5b7f555a3e2dfeb6dc046e1 # timeout=10
[2020-09-17T11:36:11.221Z] > git rev-list --no-walk c47ef905e077184bc5b7f555a3e2dfeb6dc046e1 # timeout=10
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on pull request #1459: hotfix: correct junit test timeout
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1459:
URL: https://github.com/apache/zookeeper/pull/1459#issuecomment-694131478
@TisonKun thanks for pointing this out
but the build fails with your patch
```
[2020-09-17T09:49:01.077Z] [INFO] Finished at: 2020-09-17T09:49:00Z
[2020-09-17T09:49:01.077Z] [INFO] ------------------------------------------------------------------------
[2020-09-17T09:49:01.077Z] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:testCompile (default-testCompile) on project zookeeper: Compilation failure
[2020-09-17T09:49:01.077Z] [ERROR] /home/jenkins/jenkins-home/workspace/eper-precommit-github-pr_PR-1459/zookeeper-server/src/test/java/org/apache/zookeeper/test/ReadOnlyModeTest.java:[248,21] cannot find symbol
[2020-09-17T09:49:01.077Z] [ERROR] symbol: method timeout()
[2020-09-17T09:49:01.077Z] [ERROR] location: @interface org.junit.jupiter.api.Test
[2020-09-17T09:49:01.077Z] [ERROR]
[2020-09-17T09:49:01.077Z] [ERROR] -> [Help 1]
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] eolivelli commented on pull request #1459: hotfix: correct junit test timeout
Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #1459:
URL: https://github.com/apache/zookeeper/pull/1459#issuecomment-694131972
can you please include the original JIRA id in the commit message ?
this is part of the same issue
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] LiYvbo edited a comment on pull request #1459: ZOOKEEPER-3863: correct junit test timeout
Posted by GitBox <gi...@apache.org>.
LiYvbo edited a comment on pull request #1459:
URL: https://github.com/apache/zookeeper/pull/1459#issuecomment-694178364
> Then jenkins checks out again current master !
>
> ```
>
> [2020-09-17T11:36:02.742Z] No credentials specified
>
> [2020-09-17T11:36:02.816Z] Fetching changes from the remote Git repository
>
> [2020-09-17T11:36:02.805Z] > git rev-parse --is-inside-work-tree # timeout=10
>
> [2020-09-17T11:36:02.879Z] > git config remote.origin.url https://github.com/apache/zookeeper # timeout=10
>
> [2020-09-17T11:36:02.953Z] Fetching upstream changes from https://github.com/apache/zookeeper
>
> [2020-09-17T11:36:02.953Z] > git --version # timeout=10
>
> [2020-09-17T11:36:02.957Z] > git fetch --tags --progress -- https://github.com/apache/zookeeper +refs/heads/*:refs/remotes/origin/* # timeout=10
>
> [2020-09-17T11:36:10.782Z] > git rev-parse refs/remotes/origin/master^{commit} # timeout=10
>
> [2020-09-17T11:36:10.870Z] Checking out Revision c47ef905e077184bc5b7f555a3e2dfeb6dc046e1 (refs/remotes/origin/master)
>
> [2020-09-17T11:36:11.158Z] Commit message: "ZOOKEEPER-3863: Do not track global sessions in ReadOnlyZooKeeperServer"
>
> [2020-09-17T11:36:10.856Z] > git rev-parse refs/remotes/origin/origin/master^{commit} # timeout=10
>
> [2020-09-17T11:36:10.999Z] > git config core.sparsecheckout # timeout=10
>
> [2020-09-17T11:36:11.003Z] > git checkout -f c47ef905e077184bc5b7f555a3e2dfeb6dc046e1 # timeout=10
>
> [2020-09-17T11:36:11.033Z] > git branch -a -v --no-abbrev # timeout=10
>
> [2020-09-17T11:36:11.044Z] > git checkout -b master c47ef905e077184bc5b7f555a3e2dfeb6dc046e1 # timeout=10
>
> [2020-09-17T11:36:11.221Z] > git rev-list --no-walk c47ef905e077184bc5b7f555a3e2dfeb6dc046e1 # timeout=10
> ```
can you please restart CI check for me in this PR? The failure was caused by the same reason.. @eolivelli
https://github.com/apache/zookeeper/pull/1458
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org