You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/12/02 01:52:27 UTC

[kudu-CR] KUDU-1778. Fix LMP mismatch behavior after a replica restarts

Hello David Ribeiro Alves, Mike Percy, Kudu Jenkins,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/5309

to look at the new patch set (#3).

Change subject: KUDU-1778. Fix LMP mismatch behavior after a replica restarts
......................................................................

KUDU-1778. Fix LMP mismatch behavior after a replica restarts

This fixes an issue seen in a stress test after a cluster restart. Both
replicas had an LMP mismatch with the leader, and the tablet was unable
to make progress.

The issue turned out to be that the followers were returning 0 as their
committed index, and the leader then tried to fall back to index 1. That
index had already been GCed, and thus the leader was unable to send any
operations to the followers.

I tested this patch in the same stress test environment and the issue
didn't reproduce. This also includes a test which failed without the
fix. I looped the new test 500 times and it passed.

Change-Id: I8f1332d605f7f846a01923b3ab92f12d73462bba
---
M src/kudu/consensus/consensus_peers-test.cc
M src/kudu/consensus/consensus_queue-test.cc
M src/kudu/consensus/consensus_queue.cc
M src/kudu/consensus/consensus_queue.h
M src/kudu/consensus/raft_consensus.cc
M src/kudu/integration-tests/log_verifier.cc
M src/kudu/integration-tests/log_verifier.h
M src/kudu/integration-tests/raft_consensus-itest.cc
8 files changed, 155 insertions(+), 34 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/09/5309/3
-- 
To view, visit http://gerrit.cloudera.org:8080/5309
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I8f1332d605f7f846a01923b3ab92f12d73462bba
Gerrit-PatchSet: 3
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: David Ribeiro Alves <dr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Tidy Bot