You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@myfaces.apache.org by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org> on 2011/08/02 04:28:27 UTC

[jira] [Created] (MYFACES-3254) UIComponent.popComponentFromEL should only pop when the right component is passed

UIComponent.popComponentFromEL should only pop when the right component is passed
---------------------------------------------------------------------------------

                 Key: MYFACES-3254
                 URL: https://issues.apache.org/jira/browse/MYFACES-3254
             Project: MyFaces Core
          Issue Type: Improvement
          Components: JSR-314
            Reporter: Leonardo Uribe
            Assignee: Leonardo Uribe


The code in UIComponent.popComponentFromEL does not check cases where some bad written code tries to pop a component, or just there is a missing pop.

In theory good code has push/pop in pairs, but sometimes this is not good enough and our code does not check if the component can be pop out. It could be good if we can check this condition and deal with it.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Resolved] (MYFACES-3254) UIComponent.popComponentFromEL should only pop when the right component is passed

Posted by "Leonardo Uribe (JIRA)" <de...@myfaces.apache.org>.
     [ https://issues.apache.org/jira/browse/MYFACES-3254?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Leonardo Uribe resolved MYFACES-3254.
-------------------------------------

       Resolution: Fixed
    Fix Version/s: 2.1.2
                   2.0.8

> UIComponent.popComponentFromEL should only pop when the right component is passed
> ---------------------------------------------------------------------------------
>
>                 Key: MYFACES-3254
>                 URL: https://issues.apache.org/jira/browse/MYFACES-3254
>             Project: MyFaces Core
>          Issue Type: Improvement
>          Components: JSR-314
>            Reporter: Leonardo Uribe
>            Assignee: Leonardo Uribe
>             Fix For: 2.0.8, 2.1.2
>
>
> The code in UIComponent.popComponentFromEL does not check cases where some bad written code tries to pop a component, or just there is a missing pop.
> In theory good code has push/pop in pairs, but sometimes this is not good enough and our code does not check if the component can be pop out. It could be good if we can check this condition and deal with it.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira