You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by wu...@apache.org on 2021/03/04 03:34:55 UTC

[skywalking] branch master updated: Remove unnecessary check for getSkyWalkingDynamicField invocation (#6480)

This is an automated email from the ASF dual-hosted git repository.

wusheng pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/skywalking.git


The following commit(s) were added to refs/heads/master by this push:
     new 871fdf2  Remove unnecessary check for getSkyWalkingDynamicField invocation (#6480)
871fdf2 is described below

commit 871fdf2fa251e3e2c3082a2373e4ead6c4aec8fd
Author: Jingguo Yao <ya...@gmail.com>
AuthorDate: Thu Mar 4 11:34:28 2021 +0800

    Remove unnecessary check for getSkyWalkingDynamicField invocation (#6480)
---
 .../apm/plugin/kafka/CallbackConstructorInterceptor.java           | 7 +------
 1 file changed, 1 insertion(+), 6 deletions(-)

diff --git a/apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalking/apm/plugin/kafka/CallbackConstructorInterceptor.java b/apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalking/apm/plugin/kafka/CallbackConstructorInterceptor.java
index 613860c..7c13d9e 100644
--- a/apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalking/apm/plugin/kafka/CallbackConstructorInterceptor.java
+++ b/apm-sniffer/apm-sdk-plugin/kafka-plugin/src/main/java/org/apache/skywalking/apm/plugin/kafka/CallbackConstructorInterceptor.java
@@ -30,12 +30,7 @@ public class CallbackConstructorInterceptor implements InstanceConstructorInterc
     @Override
     public void onConstruct(EnhancedInstance objInst, Object[] allArguments) {
         Callback callback = (Callback) allArguments[0];
-        CallbackCache cache;
-        if (null != objInst.getSkyWalkingDynamicField()) {
-            cache = (CallbackCache) objInst.getSkyWalkingDynamicField();
-        } else {
-            cache = new CallbackCache();
-        }
+        CallbackCache cache = new CallbackCache();
         cache.setCallback(callback);
         objInst.setSkyWalkingDynamicField(cache);
     }