[GitHub] [incubator-mxnet] ciyongch commented on a change in pull request #17187: [MKLDNN] Support channel wise quantization for FullyConnected

[GitBox <gi...@apache.org>]

ciyongch commented on a change in pull request #17187: [MKLDNN] Support channel wise quantization for FullyConnected
URL: https://github.com/apache/incubator-mxnet/pull/17187#discussion_r361887674
 
 

 ##########
 File path: python/mxnet/contrib/quantization.py
 ##########
 @@ -459,7 +464,8 @@ def quantize_model(sym, arg_params, aux_params,
                    data_names=('data',), label_names=('softmax_label',),
                    ctx=cpu(), excluded_sym_names=None, excluded_op_names=None, calib_mode='entropy',
                    calib_data=None, num_calib_examples=None,
-                   quantized_dtype='int8', quantize_mode='smart', logger=None):
+                   quantized_dtype='int8', quantize_mode='smart',
+                   quantize_granularity='channel-wise', logger=None):
 
 Review comment:
   Good catch, forget to change back to `tensor-wise` as default value after validation :) Will change default value to `tensor-wise`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services