You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by "dragon-zhang (via GitHub)" <gi...@apache.org> on 2024/01/30 13:12:37 UTC
[PR] [ISSUE dubbo#11900] part2 init dubbo-wasm-cluster-api module [dubbo-spi-extensions]
dragon-zhang opened a new pull request, #283:
URL: https://github.com/apache/dubbo-spi-extensions/pull/283
## What is the purpose of the change
see https://github.com/apache/dubbo/issues/11900
## Brief changelog
@AlbumenJ please review.
## Verifying this change
see `org.apache.dubbo.wasm.cluster.AbstractWasmLoadBalanceTest` and `org.apache.dubbo.wasm.cluster.AbstractWasmRouterTest`
Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [GITHUB_issue](https://github.com/apache/dubbo/issues) field for the change (usually before
you start working on it). Trivial changes like typos do not require a GITHUB issue. Your pull request should address
just this issue, without pulling in other changes - one PR resolves one issue.
- [ ] Format the pull request title like `[Dubbo-XXX] Fix UnknownException when host config not exist #XXX`. Each commit
in the pull request should have a meaningful subject line and body.
- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency
exist. If the new feature or significant change is committed, please remember to add sample
in [dubbo samples](https://github.com/apache/dubbo-samples) project.
- [ ] Run `mvn clean install -DskipTests=false` & `mvn clean test-compile failsafe:integration-test` to make sure
unit-test and integration-test pass.
- [ ] If this contribution is large, please follow
the [Software Donation Guide](https://github.com/apache/dubbo/wiki/Software-donation-guide).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [ISSUE dubbo#11900] part2 init dubbo-wasm-cluster-api module [dubbo-spi-extensions]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #283:
URL: https://github.com/apache/dubbo-spi-extensions/pull/283#issuecomment-1916836336
## [Codecov](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/283?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
All modified and coverable lines are covered by tests :white_check_mark:
> Comparison is base [(`efd18a6`)](https://app.codecov.io/gh/apache/dubbo-spi-extensions/commit/efd18a63468f817a7581fea44e9e2e3f35d9c9ba?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 25.17% compared to head [(`44b413f`)](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/283?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) 25.46%.
> Report is 1 commits behind head on master.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #283 +/- ##
============================================
+ Coverage 25.17% 25.46% +0.28%
- Complexity 1007 1019 +12
============================================
Files 285 287 +2
Lines 13154 13201 +47
Branches 1703 1701 -2
============================================
+ Hits 3312 3361 +49
Misses 9504 9504
+ Partials 338 336 -2
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/dubbo-spi-extensions/pull/283?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
Re: [PR] [ISSUE dubbo#11900] part2 init dubbo-wasm-cluster-api module [dubbo-spi-extensions]
Posted by "songxiaosheng (via GitHub)" <gi...@apache.org>.
songxiaosheng merged PR #283:
URL: https://github.com/apache/dubbo-spi-extensions/pull/283
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org