You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tapestry.apache.org by "Jens Breitenstein (JIRA)" <ji...@apache.org> on 2011/08/29 17:26:37 UTC
[jira] [Created] (TAP5-1623) @Parameter and @Property mutally
exclusiv?
@Parameter and @Property mutally exclusiv?
------------------------------------------
Key: TAP5-1623
URL: https://issues.apache.org/jira/browse/TAP5-1623
Project: Tapestry 5
Issue Type: Bug
Components: tapestry-core
Affects Versions: 5.2.6
Reporter: Jens Breitenstein
Priority: Minor
in case a @parameter annotation is used in conjunction with @property the property setter is never called.
the framework should either support it or reject such a combination of annotations.
sample:
@Property(read = true, write = false)
@Parameter(required = true)
private String _myParam;
// ---->> NEVER CALLED
public void String setMyParam(final String param)
{
_myParam = param;
// do more...
}
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1623) @Parameter and @Property mutually
exclusiv?
Posted by "Josh Canfield (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093181#comment-13093181 ]
Josh Canfield commented on TAP5-1623:
-------------------------------------
is the problem that adding @Property causes the setter to not get called, or that @Parameter doesn't call the setter either way?
> @Parameter and @Property mutually exclusiv?
> -------------------------------------------
>
> Key: TAP5-1623
> URL: https://issues.apache.org/jira/browse/TAP5-1623
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.6
> Reporter: Jens Breitenstein
> Priority: Minor
>
> in case a @parameter annotation is used in conjunction with @property the property setter is never called.
> the framework should either support it or reject such a combination of annotations.
> sample:
> @Property(read = true, write = false)
> @Parameter(required = true)
> private String _myParam;
> // ---->> NEVER CALLED
> public void String setMyParam(final String param)
> {
> _myParam = param;
> // do more...
> }
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1623) @Parameter and @Property mutually
exclusiv?
Posted by "Jens Breitenstein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jens Breitenstein updated TAP5-1623:
------------------------------------
Summary: @Parameter and @Property mutually exclusiv? (was: @Parameter and @Property mutally exclusiv?)
> @Parameter and @Property mutually exclusiv?
> -------------------------------------------
>
> Key: TAP5-1623
> URL: https://issues.apache.org/jira/browse/TAP5-1623
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.6
> Reporter: Jens Breitenstein
> Priority: Minor
>
> in case a @parameter annotation is used in conjunction with @property the property setter is never called.
> the framework should either support it or reject such a combination of annotations.
> sample:
> @Property(read = true, write = false)
> @Parameter(required = true)
> private String _myParam;
> // ---->> NEVER CALLED
> public void String setMyParam(final String param)
> {
> _myParam = param;
> // do more...
> }
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (TAP5-1623) @Parameter and @Property mutually
exclusiv?
Posted by "Jens Breitenstein (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jens Breitenstein reopened TAP5-1623:
-------------------------------------
Howard,
I apologize for the typo in my example. even nothing prevents a setter from returning a value you are correct in telling it should not.
but closing the bug is of no help because changing my sample code to use void as result type does not change the broken behaviour: the setter is still not called.
please check yourself with the test sources below
----------
TestSetterComponent.java
import org.apache.tapestry5.annotations.Parameter;
import org.apache.tapestry5.annotations.Property;
public class TestSetterComponent
{
@Parameter(required = true)
@Property(write = false, read = true)
private String _text;
public void setText(final String text)
{
System.out.println("DO WHATEVER YOU WANT HERE IN THIS METHOD");
_text = text + "-SETTER-CALL";
}
}
-----------------
TestSetterComponent.tml
<t:container
xmlns="http://www.w3.org/1999/xhtml"
xmlns:t="http://tapestry.apache.org/schema/tapestry_5_1_0.xsd"
xmlns:p="tapestry:parameter">
<t:if test="text">
<t:outputraw value="text"/>
</t:if>
</t:container>
--------
usage:
<t:TestSetterComponent text="literal:SAMPLE"/>
results in
SAMPLE
because the setter is never called. Personally I would expect SAMPLE-SETTER-CALL as result.
> @Parameter and @Property mutually exclusiv?
> -------------------------------------------
>
> Key: TAP5-1623
> URL: https://issues.apache.org/jira/browse/TAP5-1623
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.6
> Reporter: Jens Breitenstein
> Assignee: Howard M. Lewis Ship
> Priority: Minor
>
> in case a @parameter annotation is used in conjunction with @property the property setter is never called.
> the framework should either support it or reject such a combination of annotations.
> sample:
> @Property(read = true, write = false)
> @Parameter(required = true)
> private String _myParam;
> // ---->> NEVER CALLED
> public void String setMyParam(final String param)
> {
> _myParam = param;
> // do more...
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1623) @Parameter and @Property mutually
exclusiv?
Posted by "Jens Breitenstein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093271#comment-13093271 ]
Jens Breitenstein commented on TAP5-1623:
-----------------------------------------
It looks like the parameter write operation solely affects the class member but ignores the property annotation. Accessing the getter from the page works as usual (using getter when available). Thus I believe the @Property is not broken in general when used with @Parameter, but a parameter silently ignores a property annotation. From the debugger I guess T5 creates wrapper around parameters and defers any activity until the parameter is first used and maybe this wrapper code is not aware of a potential page @property?
> @Parameter and @Property mutually exclusiv?
> -------------------------------------------
>
> Key: TAP5-1623
> URL: https://issues.apache.org/jira/browse/TAP5-1623
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.6
> Reporter: Jens Breitenstein
> Priority: Minor
>
> in case a @parameter annotation is used in conjunction with @property the property setter is never called.
> the framework should either support it or reject such a combination of annotations.
> sample:
> @Property(read = true, write = false)
> @Parameter(required = true)
> private String _myParam;
> // ---->> NEVER CALLED
> public void String setMyParam(final String param)
> {
> _myParam = param;
> // do more...
> }
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TAP5-1623) @Parameter and @Property mutually
exclusiv?
Posted by "Howard M. Lewis Ship (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-1623.
--------------------------------------
Resolution: Invalid
Assignee: Howard M. Lewis Ship
Your example is broken. Setter methods return void, not String.
> @Parameter and @Property mutually exclusiv?
> -------------------------------------------
>
> Key: TAP5-1623
> URL: https://issues.apache.org/jira/browse/TAP5-1623
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.6
> Reporter: Jens Breitenstein
> Assignee: Howard M. Lewis Ship
> Priority: Minor
>
> in case a @parameter annotation is used in conjunction with @property the property setter is never called.
> the framework should either support it or reject such a combination of annotations.
> sample:
> @Property(read = true, write = false)
> @Parameter(required = true)
> private String _myParam;
> // ---->> NEVER CALLED
> public void String setMyParam(final String param)
> {
> _myParam = param;
> // do more...
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (TAP5-1623) @Parameter and @Property mutually
exclusiv?
Posted by "Jens Breitenstein (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jens Breitenstein reopened TAP5-1623:
-------------------------------------
Howard,
I apologize for the typo in my example. even nothing prevents a setter from returning a value you are correct in telling it should not.
but closing the bug is of no help because changing my sample code to use void as result type does not change the broken behaviour: the setter is still not called.
please check yourself with the test sources below
----------
TestSetterComponent.java
import org.apache.tapestry5.annotations.Parameter;
import org.apache.tapestry5.annotations.Property;
public class TestSetterComponent
{
@Parameter(required = true)
@Property(write = false, read = true)
private String _text;
public void setText(final String text)
{
System.out.println("DO WHATEVER YOU WANT HERE IN THIS METHOD");
_text = text + "-SETTER-CALL";
}
}
-----------------
TestSetterComponent.tml
<t:container
xmlns="http://www.w3.org/1999/xhtml"
xmlns:t="http://tapestry.apache.org/schema/tapestry_5_1_0.xsd"
xmlns:p="tapestry:parameter">
<t:if test="text">
<t:outputraw value="text"/>
</t:if>
</t:container>
--------
usage:
<t:TestSetterComponent text="literal:SAMPLE"/>
results in
SAMPLE
because the setter is never called. Personally I would expect SAMPLE-SETTER-CALL as result.
> @Parameter and @Property mutually exclusiv?
> -------------------------------------------
>
> Key: TAP5-1623
> URL: https://issues.apache.org/jira/browse/TAP5-1623
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.6
> Reporter: Jens Breitenstein
> Assignee: Howard M. Lewis Ship
> Priority: Minor
>
> in case a @parameter annotation is used in conjunction with @property the property setter is never called.
> the framework should either support it or reject such a combination of annotations.
> sample:
> @Property(read = true, write = false)
> @Parameter(required = true)
> private String _myParam;
> // ---->> NEVER CALLED
> public void String setMyParam(final String param)
> {
> _myParam = param;
> // do more...
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TAP5-1623) @Parameter and @Property mutually
exclusiv?
Posted by "Howard M. Lewis Ship (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship resolved TAP5-1623.
----------------------------------------
Resolution: Invalid
> @Parameter and @Property mutually exclusiv?
> -------------------------------------------
>
> Key: TAP5-1623
> URL: https://issues.apache.org/jira/browse/TAP5-1623
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.6
> Reporter: Jens Breitenstein
> Assignee: Howard M. Lewis Ship
> Priority: Minor
>
> in case a @parameter annotation is used in conjunction with @property the property setter is never called.
> the framework should either support it or reject such a combination of annotations.
> sample:
> @Property(read = true, write = false)
> @Parameter(required = true)
> private String _myParam;
> // ---->> NEVER CALLED
> public void String setMyParam(final String param)
> {
> _myParam = param;
> // do more...
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TAP5-1623) @Parameter and @Property mutually
exclusiv?
Posted by "Jens Breitenstein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jens Breitenstein updated TAP5-1623:
------------------------------------
Summary: @Parameter and @Property mutually exclusiv? (was: @Parameter and @Property mutally exclusiv?)
> @Parameter and @Property mutually exclusiv?
> -------------------------------------------
>
> Key: TAP5-1623
> URL: https://issues.apache.org/jira/browse/TAP5-1623
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.6
> Reporter: Jens Breitenstein
> Priority: Minor
>
> in case a @parameter annotation is used in conjunction with @property the property setter is never called.
> the framework should either support it or reject such a combination of annotations.
> sample:
> @Property(read = true, write = false)
> @Parameter(required = true)
> private String _myParam;
> // ---->> NEVER CALLED
> public void String setMyParam(final String param)
> {
> _myParam = param;
> // do more...
> }
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1623) @Parameter and @Property mutually
exclusiv?
Posted by "Howard M. Lewis Ship (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133121#comment-13133121 ]
Howard M. Lewis Ship commented on TAP5-1623:
--------------------------------------------
Setter methods must return void; otherwise java.beans.Introspector does not recognize them as a setter method.
@Property w/ a parameter DOES NOT do what you think. Tapestry does not, by design, use a setter method, even when one is available. Reading a parameter is reading the field (not the property, if any). Updating the property bound to a parameter is writing the field (not the property, if any).
<t:testsettercomponent text="literal:sample"/>
binds the text parameter of TestSetterComponent to the read-only binding for the literal value "sample". It does not, should not, will not, invoke a setter method. This is pretty clear in the docs, that Tapestry instruments the field, not the property.
> @Parameter and @Property mutually exclusiv?
> -------------------------------------------
>
> Key: TAP5-1623
> URL: https://issues.apache.org/jira/browse/TAP5-1623
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.6
> Reporter: Jens Breitenstein
> Assignee: Howard M. Lewis Ship
> Priority: Minor
>
> in case a @parameter annotation is used in conjunction with @property the property setter is never called.
> the framework should either support it or reject such a combination of annotations.
> sample:
> @Property(read = true, write = false)
> @Parameter(required = true)
> private String _myParam;
> // ---->> NEVER CALLED
> public void String setMyParam(final String param)
> {
> _myParam = param;
> // do more...
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (TAP5-1623) @Parameter and @Property mutually
exclusiv?
Posted by "Howard M. Lewis Ship (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship resolved TAP5-1623.
----------------------------------------
Resolution: Invalid
> @Parameter and @Property mutually exclusiv?
> -------------------------------------------
>
> Key: TAP5-1623
> URL: https://issues.apache.org/jira/browse/TAP5-1623
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.6
> Reporter: Jens Breitenstein
> Assignee: Howard M. Lewis Ship
> Priority: Minor
>
> in case a @parameter annotation is used in conjunction with @property the property setter is never called.
> the framework should either support it or reject such a combination of annotations.
> sample:
> @Property(read = true, write = false)
> @Parameter(required = true)
> private String _myParam;
> // ---->> NEVER CALLED
> public void String setMyParam(final String param)
> {
> _myParam = param;
> // do more...
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (TAP5-1623) @Parameter and @Property mutually
exclusiv?
Posted by "Howard M. Lewis Ship (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Howard M. Lewis Ship closed TAP5-1623.
--------------------------------------
Resolution: Invalid
Assignee: Howard M. Lewis Ship
Your example is broken. Setter methods return void, not String.
> @Parameter and @Property mutually exclusiv?
> -------------------------------------------
>
> Key: TAP5-1623
> URL: https://issues.apache.org/jira/browse/TAP5-1623
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.6
> Reporter: Jens Breitenstein
> Assignee: Howard M. Lewis Ship
> Priority: Minor
>
> in case a @parameter annotation is used in conjunction with @property the property setter is never called.
> the framework should either support it or reject such a combination of annotations.
> sample:
> @Property(read = true, write = false)
> @Parameter(required = true)
> private String _myParam;
> // ---->> NEVER CALLED
> public void String setMyParam(final String param)
> {
> _myParam = param;
> // do more...
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1623) @Parameter and @Property mutually
exclusiv?
Posted by "Josh Canfield (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093181#comment-13093181 ]
Josh Canfield commented on TAP5-1623:
-------------------------------------
is the problem that adding @Property causes the setter to not get called, or that @Parameter doesn't call the setter either way?
> @Parameter and @Property mutually exclusiv?
> -------------------------------------------
>
> Key: TAP5-1623
> URL: https://issues.apache.org/jira/browse/TAP5-1623
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.6
> Reporter: Jens Breitenstein
> Priority: Minor
>
> in case a @parameter annotation is used in conjunction with @property the property setter is never called.
> the framework should either support it or reject such a combination of annotations.
> sample:
> @Property(read = true, write = false)
> @Parameter(required = true)
> private String _myParam;
> // ---->> NEVER CALLED
> public void String setMyParam(final String param)
> {
> _myParam = param;
> // do more...
> }
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1623) @Parameter and @Property mutually
exclusiv?
Posted by "Jens Breitenstein (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093271#comment-13093271 ]
Jens Breitenstein commented on TAP5-1623:
-----------------------------------------
It looks like the parameter write operation solely affects the class member but ignores the property annotation. Accessing the getter from the page works as usual (using getter when available). Thus I believe the @Property is not broken in general when used with @Parameter, but a parameter silently ignores a property annotation. From the debugger I guess T5 creates wrapper around parameters and defers any activity until the parameter is first used and maybe this wrapper code is not aware of a potential page @property?
> @Parameter and @Property mutually exclusiv?
> -------------------------------------------
>
> Key: TAP5-1623
> URL: https://issues.apache.org/jira/browse/TAP5-1623
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.6
> Reporter: Jens Breitenstein
> Priority: Minor
>
> in case a @parameter annotation is used in conjunction with @property the property setter is never called.
> the framework should either support it or reject such a combination of annotations.
> sample:
> @Property(read = true, write = false)
> @Parameter(required = true)
> private String _myParam;
> // ---->> NEVER CALLED
> public void String setMyParam(final String param)
> {
> _myParam = param;
> // do more...
> }
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TAP5-1623) @Parameter and @Property mutually
exclusiv?
Posted by "Howard M. Lewis Ship (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TAP5-1623?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133121#comment-13133121 ]
Howard M. Lewis Ship commented on TAP5-1623:
--------------------------------------------
Setter methods must return void; otherwise java.beans.Introspector does not recognize them as a setter method.
@Property w/ a parameter DOES NOT do what you think. Tapestry does not, by design, use a setter method, even when one is available. Reading a parameter is reading the field (not the property, if any). Updating the property bound to a parameter is writing the field (not the property, if any).
<t:testsettercomponent text="literal:sample"/>
binds the text parameter of TestSetterComponent to the read-only binding for the literal value "sample". It does not, should not, will not, invoke a setter method. This is pretty clear in the docs, that Tapestry instruments the field, not the property.
> @Parameter and @Property mutually exclusiv?
> -------------------------------------------
>
> Key: TAP5-1623
> URL: https://issues.apache.org/jira/browse/TAP5-1623
> Project: Tapestry 5
> Issue Type: Bug
> Components: tapestry-core
> Affects Versions: 5.2.6
> Reporter: Jens Breitenstein
> Assignee: Howard M. Lewis Ship
> Priority: Minor
>
> in case a @parameter annotation is used in conjunction with @property the property setter is never called.
> the framework should either support it or reject such a combination of annotations.
> sample:
> @Property(read = true, write = false)
> @Parameter(required = true)
> private String _myParam;
> // ---->> NEVER CALLED
> public void String setMyParam(final String param)
> {
> _myParam = param;
> // do more...
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira