[GitHub] [geode-native] pdxcodemonkey commented on pull request #831: GEODE-9431: Replaced std regex with Boost due to RHEL8.

[GitBox <gi...@apache.org>]

pdxcodemonkey commented on pull request #831:
URL: https://github.com/apache/geode-native/pull/831#issuecomment-882661385


   > This seems like a really big hammer for what strikes me an issue with maybe a specific RHEL C++ runtime patch or gcc patch. I didn't see any open tickets with RHEL or GNU regarding these issues in the GEODE ticket. Given that boost::regex is the basis for std::regex if we are using std::regex incorrectly resulting in different undefined behavior in RHEL then I would be just as concerned with our use of boost::regex.
   
   I spent most of last week picking up and discarding various "hammers" as solutions to this problem - this was the first one that worked.  Let me know what mitigations you think we need for this, I'm fine with most things.  If we need/want a JIRA ticket to revert this back once it's fixed by RedHat or whomever, that's fine.  I would also argue it's not really _that_ big of a hammer, since the change itself took about an hour to make and verify, and backing it out is the work of a few minutes.  I'll figure out how to file the bug with RedHat and GNU today, but I don't think waiting for them to provide a fix is a viable strategy.  We need to get our CI pipeline off the floor so we can proceed with dev work and know we're not further damaging the product on RHEL-8.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org