You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/09/09 17:25:28 UTC
[kudu-CR] debug-util-test: address flakiness
Hello Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/4346
to review the following change.
Change subject: debug-util-test: address flakiness
......................................................................
debug-util-test: address flakiness
In TSAN builds, this test seems to fail sometimes due to not starting
the 'SleeperThread' fast enough. It used to wait only 1 second for the
thread to start. This now uses 'AssertEventually' which has a much
longer (30-second) timeout.
Change-Id: I02b1273352ac8521dee01b7e0b4d4df21e90e517
---
M src/kudu/util/debug-util-test.cc
1 file changed, 3 insertions(+), 7 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/46/4346/1
--
To view, visit http://gerrit.cloudera.org:8080/4346
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I02b1273352ac8521dee01b7e0b4d4df21e90e517
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
[kudu-CR] debug-util-test: address flakiness
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: debug-util-test: address flakiness
......................................................................
debug-util-test: address flakiness
In TSAN builds, this test seems to fail sometimes due to not starting
the 'SleeperThread' fast enough. It used to wait only 1 second for the
thread to start. This now uses 'AssertEventually' which has a much
longer (30-second) timeout.
Change-Id: I02b1273352ac8521dee01b7e0b4d4df21e90e517
Reviewed-on: http://gerrit.cloudera.org:8080/4346
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/util/debug-util-test.cc
1 file changed, 3 insertions(+), 7 deletions(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/4346
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I02b1273352ac8521dee01b7e0b4d4df21e90e517
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] debug-util-test: address flakiness
Posted by "Kudu Jenkins (Code Review)" <ge...@cloudera.org>.
Kudu Jenkins has posted comments on this change.
Change subject: debug-util-test: address flakiness
......................................................................
Patch Set 1:
Build Started http://104.196.14.100/job/kudu-gerrit/3306/
--
To view, visit http://gerrit.cloudera.org:8080/4346
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02b1273352ac8521dee01b7e0b4d4df21e90e517
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] debug-util-test: address flakiness
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: debug-util-test: address flakiness
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/4346
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I02b1273352ac8521dee01b7e0b4d4df21e90e517
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No