You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by GitBox <gi...@apache.org> on 2022/09/12 20:03:49 UTC
[GitHub] [logging-log4j2] Marcono1234 opened a new pull request, #1051: LOG4J2-2947 - Make LogBuilder methods abstract
Marcono1234 opened a new pull request, #1051:
URL: https://github.com/apache/logging-log4j2/pull/1051
The current approach of having no-op `default` methods is pretty error-prone because it is easy to forget to override a method when a class implements the interface. Additionally the documentation stating that the interface method does nothing is probably quite confusing for users, who don't care about the implementation details of Log4j 2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] Marcono1234 commented on pull request #1051: LOG4J2-2947 - Make LogBuilder methods abstract
Posted by GitBox <gi...@apache.org>.
Marcono1234 commented on PR #1051:
URL: https://github.com/apache/logging-log4j2/pull/1051#issuecomment-1244635893
It looks like the test failure is unrelated to these changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] Marcono1234 commented on pull request #1051: LOG4J2-2947 - Make LogBuilder methods abstract
Posted by GitBox <gi...@apache.org>.
Marcono1234 commented on PR #1051:
URL: https://github.com/apache/logging-log4j2/pull/1051#issuecomment-1244678174
In theory this might be a breaking change though in case users implement their own `LogBuilder` and (erronously?) had not overridden all of the methods before.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] LOG4J2-2947 - Make LogBuilder methods abstract (logging-log4j2)
Posted by "vy (via GitHub)" <gi...@apache.org>.
vy closed pull request #1051: LOG4J2-2947 - Make LogBuilder methods abstract
URL: https://github.com/apache/logging-log4j2/pull/1051
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [logging-log4j2] ppkarwasz commented on pull request #1051: LOG4J2-2947 - Make LogBuilder methods abstract
Posted by GitBox <gi...@apache.org>.
ppkarwasz commented on PR #1051:
URL: https://github.com/apache/logging-log4j2/pull/1051#issuecomment-1244655502
@Marcono1234,
Yes, they are unrelated, but you probably want to submit a PR against the current stable release `release-2.x`. The `master` branch is for the unreleased 3.x series.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] LOG4J2-2947 - Make LogBuilder methods abstract (logging-log4j2)
Posted by "ppkarwasz (via GitHub)" <gi...@apache.org>.
ppkarwasz commented on PR #1051:
URL: https://github.com/apache/logging-log4j2/pull/1051#issuecomment-1449445204
This was closed automatically by Github because we renamed the `release-2.x` branch to `2.x`. Feel free to resubmit to the `2.x` branch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@logging.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org