You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "harikrishna-patnala (via GitHub)" <gi...@apache.org> on 2023/10/06 09:13:02 UTC
[PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
harikrishna-patnala opened a new pull request, #8049:
URL: https://github.com/apache/cloudstack/pull/8049
### Description
This PR fixes the issue #8040
we are now handling any exception while setting up the memory balloon stats period
<!--- Describe your changes in DETAIL - And how has behaviour functionally changed. -->
<!-- For new features, provide link to FS, dev ML discussion etc. -->
<!-- In case of bug fix, the expected and actual behaviours, steps to reproduce. -->
<!-- When "Fixes: #<id>" is specified, the issue/PR will automatically be closed when this PR gets merged -->
<!-- For addressing multiple issues/PRs, use multiple "Fixes: #<id>" -->
<!-- Fixes: # -->
<!--- ********************************************************************************* -->
<!--- NOTE: AUTOMATATION USES THE DESCRIPTIONS TO SET LABELS AND PRODUCE DOCUMENTATION. -->
<!--- PLEASE PUT AN 'X' in only **ONE** box -->
<!--- ********************************************************************************* -->
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
- [ ] build/CI
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
#### How did you try to break this feature and the system with this change?
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1752766285
> Should we consider VMs not managed by ACS in Agent start up? Would not it be easier to filter out those VMs?
@GutoVeronezi
we had some discussion on the issue https://github.com/apache/cloudstack/issues/8040
the problem is how to accurately determine if a vm is managed on ACS or not in kvm agent (which cannot read cloudstack database), especially considering that the kvm import feature will be introduced in 4.19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1782791215
@DaanHoogland a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1783659035
<b>[SF] Trillian test result (tid-8138)</b>
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 47615 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8049-t8138-kvm-rocky8.zip
Smoke tests completed. 109 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "GutoVeronezi (via GitHub)" <gi...@apache.org>.
GutoVeronezi commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1752772004
> > Should we consider VMs not managed by ACS in Agent start up? Would not it be easier to filter out those VMs?
>
> @GutoVeronezi we had some discussion on the issue #8040 the problem is how to accurately determine if a vm is managed on ACS or not in kvm agent (which cannot read cloudstack database), especially considering that the kvm import feature will be introduced in 4.19
I see, thanks @weizhouapache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1782550092
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1782710819
@blueorangutan LLtest basicZone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1758325252
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1758438613
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7329
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on code in PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#discussion_r1349950583
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -1313,8 +1313,8 @@ protected void setupMemoryBalloonStatsPeriod(Connect conn) {
}
s_logger.debug(String.format("The memory balloon stats period [%s] has been set successfully for the VM (Libvirt Domain) with ID [%s] and name [%s].",
currentVmBalloonStatsPeriod, vmId, dm.getName()));
- } catch (final LibvirtException e) {
- s_logger.warn("Failed to set up memory balloon stats period." + e.getMessage());
+ } catch (final Exception e) {
Review Comment:
@DaanHoogland we are trying to read many other parameters in that parser. so there are chances of other errors such as NPEs, cast errors. While discussing with Wei several other found in IDE, so thought a common exception could catch it and warn the message.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1769989142
@DaanHoogland do you want me to improve this code to handle specific exceptions ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1784618873
smoke tests for security groups and basic zone are expected to have such a low pass rate.
regular smoke tests look fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1750343431
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7252
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1750416102
## [Codecov](https://app.codecov.io/gh/apache/cloudstack/pull/8049?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#8049](https://app.codecov.io/gh/apache/cloudstack/pull/8049?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (788e08b) into [4.18](https://app.codecov.io/gh/apache/cloudstack/commit/a20ab40b674b313fafc3b4cb18f938107324c16a?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (a20ab40) will **increase** coverage by `0.00%`.
> The diff coverage is `33.33%`.
```diff
@@ Coverage Diff @@
## 4.18 #8049 +/- ##
=========================================
Coverage 13.07% 13.07%
- Complexity 9109 9110 +1
=========================================
Files 2720 2720
Lines 257530 257535 +5
Branches 40154 40156 +2
=========================================
+ Hits 33660 33668 +8
+ Misses 219639 219633 -6
- Partials 4231 4234 +3
```
| [Files](https://app.codecov.io/gh/apache/cloudstack/pull/8049?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [...ervisor/kvm/resource/LibvirtComputingResource.java](https://app.codecov.io/gh/apache/cloudstack/pull/8049?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvTGlidmlydENvbXB1dGluZ1Jlc291cmNlLmphdmE=) | `18.45% <0.00%> (ø)` | |
| [...ypervisor/kvm/resource/LibvirtDomainXMLParser.java](https://app.codecov.io/gh/apache/cloudstack/pull/8049?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2UvTGlidmlydERvbWFpblhNTFBhcnNlci5qYXZh) | `50.00% <40.00%> (-0.62%)` | :arrow_down: |
... and [3 files with indirect coverage changes](https://app.codecov.io/gh/apache/cloudstack/pull/8049/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1782718337
@blueorangutan test rocky8 kvm-alma9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1782546045
@DaanHoogland @harikrishna-patnala
I think it is not a problem if ACS fails to set the memory ballooning of a specific VM, we could silently ignore the error, no matter what exceptions (LibvirtException, NPE, or others) are thrown.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1782548454
> @DaanHoogland @harikrishna-patnala I think it is not a problem if ACS fails to set the memory ballooning of a specific VM, we could silently ignore the error, no matter what exceptions (LibvirtException, NPE, or others) are thrown.
ok
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1782710152
@blueorangutan LLtest matrix basicZone
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1782790435
@blueorangutan test rocky8 kvm-rocky8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on code in PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#discussion_r1350180598
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -1313,8 +1313,8 @@ protected void setupMemoryBalloonStatsPeriod(Connect conn) {
}
s_logger.debug(String.format("The memory balloon stats period [%s] has been set successfully for the VM (Libvirt Domain) with ID [%s] and name [%s].",
currentVmBalloonStatsPeriod, vmId, dm.getName()));
- } catch (final LibvirtException e) {
- s_logger.warn("Failed to set up memory balloon stats period." + e.getMessage());
+ } catch (final Exception e) {
Review Comment:
:) So you are giving +1 on this right ;)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1750254164
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1782716936
@DaanHoogland [SL] unsupported parameters provided. Supported mgmt server os are: `centos7, centos6, suse15, alma8, ubuntu18, ubuntu22, ubuntu20, rocky8, alma9`. Supported hypervisors are: `kvm-centos6, kvm-centos7, kvm-rocky8, kvm-alma8, kvm-alma9, kvm-ubuntu18, kvm-ubuntu20, kvm-ubuntu22, kvm-suse15, vmware-55u3, vmware-60u2, vmware-65u2, vmware-67u3, vmware-70u1, vmware-70u2, vmware-70u3, vmware-80, vmware-80u1, xenserver-65sp1, xenserver-71, xenserver-74, xcpng74, xcpng76, xcpng80, xcpng81, xcpng82`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1782548973
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "GutoVeronezi (via GitHub)" <gi...@apache.org>.
GutoVeronezi commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1752762525
Should we consider VMs not managed by ACS in Agent start up? Would not it be easier to filter out those VMs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1782657472
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7545
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1750357313
@harikrishna-patnala a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1770281512
> @DaanHoogland do you want me to improve this code to handle specific exceptions ?
I would prefer that but am not going to -1 this PR because of it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1758333359
@weizhouapache a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1782711945
@DaanHoogland a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1783680715
<b>[LL]Trillian test result (tid-6873)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 57333 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8049-t6873-kvm-centos7.zip
Smoke tests completed. 56 look OK, 53 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestPortablePublicIPAcquire>:setup | `Error` | 0.00 | test_portable_publicip.py
test_DeleteDomain | `Failure` | 93.41 | test_accounts.py
test_forceDeleteDomain | `Failure` | 90.33 | test_accounts.py
test_delete_account | `Error` | 43.34 | test_network.py
test_delete_network_while_vm_on_it | `Error` | 1.12 | test_network.py
test_deploy_vm_l2network | `Error` | 1.11 | test_network.py
test_l2network_restart | `Error` | 2.23 | test_network.py
test_01_port_fwd_on_src_nat | `Failure` | 0.02 | test_network.py
test_02_port_fwd_on_non_src_nat | `Error` | 0.03 | test_network.py
ContextSuite context=TestPublicIP>:setup | `Error` | 3.46 | test_network.py
test_reboot_router | `Error` | 160.27 | test_network.py
test_releaseIP | `Error` | 39.19 | test_network.py
test_network_rules_acquired_public_ip_1_static_nat_rule | `Error` | 0.03 | test_network.py
test_network_rules_acquired_public_ip_2_nat_rule | `Error` | 0.02 | test_network.py
test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | `Error` | 0.02 | test_network.py
test_network_acl | `Error` | 2.16 | test_network_acl.py
test_01_internallb_roundrobin_1VPC_3VM_HTTP_port80 | `Failure` | 4.43 | test_internal_lb.py
test_02_internallb_roundrobin_1RVPC_3VM_HTTP_port80 | `Failure` | 4.48 | test_internal_lb.py
test_03_vpc_internallb_haproxy_stats_on_all_interfaces | `Failure` | 3.39 | test_internal_lb.py
test_04_rvpc_internallb_haproxy_stats_on_all_interfaces | `Failure` | 4.46 | test_internal_lb.py
ContextSuite context=TestIpv6Network>:setup | `Error` | 0.00 | test_network_ipv6.py
test_01_nic | `Error` | 42.95 | test_nic.py
ContextSuite context=TestRouterDHCPHosts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
ContextSuite context=TestRouterDHCPOpts>:setup | `Error` | 0.00 | test_router_dhcphosts.py
test_01_create_ipv6_public_ip_range | `Error` | 0.02 | test_ipv6_infra.py
ContextSuite context=TestRouterDns>:setup | `Error` | 0.00 | test_router_dns.py
ContextSuite context=TestRouterDnsService>:setup | `Error` | 0.00 | test_router_dnsservice.py
test_01_ping_in_vr_success | `Failure` | 0.02 | test_diagnostics.py
test_02_ping_in_vr_failure | `Failure` | 0.01 | test_diagnostics.py
test_07_arping_in_vr | `Failure` | 0.01 | test_diagnostics.py
test_10_traceroute_in_vr | `Failure` | 0.01 | test_diagnostics.py
test_13_retrieve_vr_default_files | `Failure` | 0.02 | test_diagnostics.py
test_14_retrieve_vr_one_file | `Failure` | 0.01 | test_diagnostics.py
ContextSuite context=TestIsolatedNetworksPasswdServer>:setup | `Error` | 0.00 | test_password_server.py
test_01_deploy_vm_from_direct_download_template_nfs_storage | `Error` | 0.08 | test_direct_download.py
test_01_isolated_persistent_network | `Error` | 0.03 | test_persistent_network.py
test_03_deploy_and_destroy_VM_and_verify_network_resources_persist | `Failure` | 1.25 | test_persistent_network.py
test_01_vpc_privategw_acl | `Failure` | 4.95 | test_privategw_acl.py
test_02_vpc_privategw_static_routes | `Failure` | 4.87 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 4.97 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 3.89 | test_privategw_acl.py
test_01_native_to_native_network_migration | `Error` | 1.92 | test_migration.py
test_02_native_to_native_vpc_migration | `Error` | 5.09 | test_migration.py
test_04_verify_guest_lspci | `Error` | 810.72 | test_deploy_virtio_scsi_vm.py
test_06_verify_guest_lspci_again | `Error` | 810.44 | test_deploy_virtio_scsi_vm.py
test_01_create_delete_portforwarding_fornonvpc | `Error` | 1.76 | test_portforwardingrules.py
ContextSuite context=TestNetworkPermissions>:setup | `Error` | 0.00 | test_network_permissions.py
test_03_create_network_domain_network_offering | `Error` | 5.28 | test_domain_network_offerings.py
test_extendPhysicalNetworkVlan | `Error` | 0.03 | test_non_contigiousvlan.py
test_03_create_vpc_domain_vpc_offering | `Error` | 6.38 | test_domain_vpc_offerings.py
test_01_router_internal_basic | `Failure` | 0.02 | test_routers.py
test_02_router_internal_adv | `Failure` | 0.01 | test_routers.py
test_03_restart_network_cleanup | `Failure` | 0.01 | test_routers.py
test_04_restart_network_wo_cleanup | `Failure` | 2.10 | test_routers.py
test_05_router_basic | `Failure` | 0.01 | test_routers.py
test_06_router_advanced | `Failure` | 0.01 | test_routers.py
test_07_stop_router | `Failure` | 0.01 | test_routers.py
test_08_start_router | `Failure` | 0.01 | test_routers.py
test_09_reboot_router | `Failure` | 0.01 | test_routers.py
test_10_reboot_router_forced | `Failure` | 0.01 | test_routers.py
ContextSuite context=TestLoadBalance>:setup | `Error` | 0.00 | test_loadbalance.py
ContextSuite context=TestLBRuleUsage>:setup | `Error` | 40.05 | test_usage.py
ContextSuite context=TestNatRuleUsage>:setup | `Error` | 77.98 | test_usage.py
ContextSuite context=TestPublicIPUsage>:setup | `Error` | 115.96 | test_usage.py
ContextSuite context=TestVpnUsage>:setup | `Error` | 244.71 | test_usage.py
test_01_events_resource | `Error` | 1.78 | test_events_resource.py
ContextSuite context=TestNonStrictAffinityGroups>:setup | `Error` | 0.00 | test_nonstrict_affinity_group.py
test_dedicatePublicIpRange | `Error` | 0.02 | test_public_ip_range.py
test_dedicate_public_ip_range_for_system_vms | `Error` | 0.01 | test_public_ip_range.py
test_dedicate_public_ip_range_for_system_vms_01_ssvm | `Error` | 0.05 | test_public_ip_range.py
test_dedicate_public_ip_range_for_system_vms_02_cpvm | `Error` | 0.05 | test_public_ip_range.py
test_create_pvlan_network | `Error` | 0.06 | test_pvlan.py
test_dedicateGuestVlanRange | `Error` | 0.00 | test_guest_vlan_range.py
ContextSuite context=TestDedicateGuestVlanRange>:teardown | `Error` | 0.00 | test_guest_vlan_range.py
ContextSuite context=TestHostControlState>:setup | `Error` | 0.00 | test_host_control_state.py
test_CRUD_operations_userdata | `Error` | 1.76 | test_register_userdata.py
test_deploy_vm_with_registered_userdata | `Error` | 1.72 | test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_allow | `Error` | 1.78 | test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_append | `Error` | 1.72 | test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_deny | `Error` | 1.77 | test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_params | `Error` | 1.73 | test_register_userdata.py
test_link_and_unlink_userdata_to_template | `Error` | 1.72 | test_register_userdata.py
test_user_userdata_crud | `Error` | 1.75 | test_register_userdata.py
test_01_create_iso_with_checksum_sha1 | `Error` | 66.40 | test_iso.py
test_02_create_iso_with_checksum_sha256 | `Error` | 66.37 | test_iso.py
test_03_create_iso_with_checksum_md5 | `Error` | 66.38 | test_iso.py
test_04_create_iso_with_no_checksum | `Error` | 66.37 | test_iso.py
test_01_create_iso | `Failure` | 1514.03 | test_iso.py
ContextSuite context=TestISO>:setup | `Error` | 3027.15 | test_iso.py
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
test_10_vpc_tier_kubernetes_cluster | `Failure` | 0.00 | test_kubernetes_clusters.py
ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py
ContextSuite context=TestIsolatedNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
ContextSuite context=TestRedundantIsolateNetworks>:setup | `Error` | 0.00 | test_routers_network_ops.py
test_01_add_delete_kubernetes_supported_version | `Error` | 0.04 | test_kubernetes_supported_versions.py
test_01_sys_vm_start | `Failure` | 0.07 | test_secondary_storage.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
ContextSuite context=TestRouterIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestVPCIpTablesPolicies>:setup | `Error` | 0.00 | test_routers_iptables_default_policy.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 0.14 | test_service_offerings.py
ContextSuite context=TestVMWareStoragePolicies>:setup | `Error` | 0.00 | test_storage_policy.py
ContextSuite context=TestVmAutoScaling>:setup | `Error` | 0.00 | test_vm_autoscaling.py
test_01_deploy_vm_on_specific_host | `Error` | 1.21 | test_vm_deployment_planner.py
test_02_deploy_vm_on_specific_cluster | `Error` | 1.19 | test_vm_deployment_planner.py
test_03_deploy_vm_on_specific_pod | `Error` | 1.25 | test_vm_deployment_planner.py
test_04_deploy_vm_on_host_override_pod_and_cluster | `Error` | 1.21 | test_vm_deployment_planner.py
test_05_deploy_vm_on_cluster_override_pod | `Error` | 1.18 | test_vm_deployment_planner.py
ContextSuite context=TestDeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=TestVMLifeCycle>:setup | `Error` | 2.84 | test_vm_life_cycle.py
ContextSuite context=TestVmSnapshot>:setup | `Error` | 2.84 | test_vm_snapshots.py
ContextSuite context=TestCreateVolume>:setup | `Error` | 0.00 | test_volumes.py
ContextSuite context=TestVolumes>:setup | `Error` | 4.07 | test_volumes.py
ContextSuite context=TestIpv6Vpc>:setup | `Error` | 0.00 | test_vpc_ipv6.py
ContextSuite context=TestVPCRedundancy>:setup | `Error` | 0.00 | test_vpc_redundant.py
ContextSuite context=TestVPCNics>:setup | `Error` | 0.00 | test_vpc_router_nics.py
ContextSuite context=TestRVPCSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVPCSite2SiteVPNMultipleOptions>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcRemoteAccessVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
ContextSuite context=TestVpcSite2SiteVpn>:setup | `Error` | 0.00 | test_vpc_vpn.py
test_disable_oobm_ha_state_ineligible | `Error` | 1512.26 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1783042795
<b>[LL]Trillian test result (tid-6872)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 12259 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8049-t6872-kvm-centos7.zip
Smoke tests completed. 100 look OK, 9 have errors, 0 did not run
Only failed and skipped tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
ContextSuite context=TestIpv6Network>:setup | `Error` | 0.00 | test_network_ipv6.py
test_01_create_ipv6_public_ip_range | `Error` | 0.02 | test_ipv6_infra.py
test_deploy_more_vms_than_limit_allows | `Failure` | 50.48 | test_deploy_vms_in_parallel.py
test_03_restart_network_cleanup | `Error` | 1.08 | test_routers.py
test_01_events_resource | `Error` | 1.84 | test_events_resource.py
test_CRUD_operations_userdata | `Error` | 1.76 | test_register_userdata.py
test_deploy_vm_with_registered_userdata | `Error` | 1.80 | test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_allow | `Error` | 1.76 | test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_append | `Error` | 1.78 | test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_override_policy_deny | `Error` | 1.76 | test_register_userdata.py
test_deploy_vm_with_registered_userdata_with_params | `Error` | 1.78 | test_register_userdata.py
test_link_and_unlink_userdata_to_template | `Error` | 1.77 | test_register_userdata.py
test_user_userdata_crud | `Error` | 1.76 | test_register_userdata.py
test_08_migrate_vm | `Error` | 1.15 | test_vm_life_cycle.py
ContextSuite context=TestIpv6Vpc>:setup | `Error` | 0.00 | test_vpc_ipv6.py
test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 0.22 | test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 0.27 | test_host_maintenance.py
ContextSuite context=TestHostMaintenanceAgents>:setup | `Error` | 0.42 | test_host_maintenance.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "harikrishna-patnala (via GitHub)" <gi...@apache.org>.
harikrishna-patnala commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1750355186
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1750452067
Packaging result [SF]: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: el9 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 7253
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1782714422
@DaanHoogland a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1782713649
@blueorangutan LLtest securityGroups
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1782759874
<b>[SF] Trillian Build Failed (tid-8137)<b/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1782719310
@DaanHoogland a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-alma9) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "weizhouapache (via GitHub)" <gi...@apache.org>.
weizhouapache merged PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1782714758
@blueorangutan test rocky8 kvm-ol9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#discussion_r1350050410
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -1313,8 +1313,8 @@ protected void setupMemoryBalloonStatsPeriod(Connect conn) {
}
s_logger.debug(String.format("The memory balloon stats period [%s] has been set successfully for the VM (Libvirt Domain) with ID [%s] and name [%s].",
currentVmBalloonStatsPeriod, vmId, dm.getName()));
- } catch (final LibvirtException e) {
- s_logger.warn("Failed to set up memory balloon stats period." + e.getMessage());
+ } catch (final Exception e) {
Review Comment:
ok, I hate it and I would like to see a message per exception, but no -1 for that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "blueorangutan (via GitHub)" <gi...@apache.org>.
blueorangutan commented on PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#issuecomment-1750255073
@harikrishna-patnala a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix KVM cloudstack-agent start if there is vm not managed by cloudstack on the host [cloudstack]
Posted by "DaanHoogland (via GitHub)" <gi...@apache.org>.
DaanHoogland commented on code in PR #8049:
URL: https://github.com/apache/cloudstack/pull/8049#discussion_r1348615190
##########
plugins/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/resource/LibvirtComputingResource.java:
##########
@@ -1313,8 +1313,8 @@ protected void setupMemoryBalloonStatsPeriod(Connect conn) {
}
s_logger.debug(String.format("The memory balloon stats period [%s] has been set successfully for the VM (Libvirt Domain) with ID [%s] and name [%s].",
currentVmBalloonStatsPeriod, vmId, dm.getName()));
- } catch (final LibvirtException e) {
- s_logger.warn("Failed to set up memory balloon stats period." + e.getMessage());
+ } catch (final Exception e) {
Review Comment:
Is this needed or can we add a specific Exception to the catch clause?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org