You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by mattyb149 <gi...@git.apache.org> on 2017/09/25 16:26:16 UTC
[GitHub] nifi pull request #2174: NIFI-4345: Removed lookup-services dependency from ...
GitHub user mattyb149 opened a pull request:
https://github.com/apache/nifi/pull/2174
NIFI-4345: Removed lookup-services dependency from MongoDB Services NAR, cleaned up dependencies
Thank you for submitting a contribution to Apache NiFi.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
- [x] Is your initial contribution a single, squashed commit?
### For code changes:
- [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
- [ ] Have you written or updated unit tests to verify your changes?
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
- [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
- [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mattyb149/nifi NIFI-4345_2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/nifi/pull/2174.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2174
----
commit abee5c45d031ba0586514761ba1fa9c24a705a6a
Author: Matthew Burgess <ma...@apache.org>
Date: 2017-09-25T16:22:10Z
NIFI-4345: Removed lookup-services dependency from MongoDB Services NAR, cleaned up deps
----
---
[GitHub] nifi issue #2174: NIFI-4345: Removed lookup-services dependency from MongoDB...
Posted by bbende <gi...@git.apache.org>.
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2174
Reviewing...
---
[GitHub] nifi pull request #2174: NIFI-4345: Removed lookup-services dependency from ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2174
---
[GitHub] nifi issue #2174: NIFI-4345: Removed lookup-services dependency from MongoDB...
Posted by bbende <gi...@git.apache.org>.
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2174
Can we also add nifi-lookup-service-api as provided in the nar-bundles pom?
I noticed that the lookup service api JAR was included in a couple of places that was unnecessary...
```
find work/ -name *lookup-service-api*
work//nar/extensions/nifi-lookup-services-nar-1.4.0-SNAPSHOT.nar-unpacked/META-INF/bundled-dependencies/nifi-lookup-service-api-1.4.0-SNAPSHOT.jar
work//nar/extensions/nifi-mongodb-services-nar-1.4.0-SNAPSHOT.nar-unpacked/META-INF/bundled-dependencies/nifi-lookup-service-api-1.4.0-SNAPSHOT.jar
work//nar/extensions/nifi-scripting-nar-1.4.0-SNAPSHOT.nar-unpacked/META-INF/bundled-dependencies/nifi-lookup-service-api-1.4.0-SNAPSHOT.jar
work//nar/extensions/nifi-standard-nar-1.4.0-SNAPSHOT.nar-unpacked/META-INF/bundled-dependencies/nifi-lookup-service-api-1.4.0-SNAPSHOT.jar
work//nar/extensions/nifi-standard-services-api-nar-1.4.0-SNAPSHOT.nar-unpacked/META-INF/bundled-dependencies/nifi-lookup-service-api-1.4.0-SNAPSHOT.jar
```
If we add it as provided in the dependency management section of nar-bundles then it should only show up in nifi-standard-services-api-nar.
---
[GitHub] nifi issue #2174: NIFI-4345: Removed lookup-services dependency from MongoDB...
Posted by bbende <gi...@git.apache.org>.
Github user bbende commented on the issue:
https://github.com/apache/nifi/pull/2174
+1 Looks good, will merge to master
---