You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/08/22 15:09:33 UTC

[GitHub] [shardingsphere] sandynz opened a new pull request #6998: Fix #6579 : Support PostgreSQL unspecified parameter data type

sandynz opened a new pull request #6998:
URL: https://github.com/apache/shardingsphere/pull/6998


   Fixes #6579 .
   
   Changes proposed in this pull request:
   - Support PostgreSQL unspecified parameter data type
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] coveralls commented on pull request #6998: Fix #6579 : Support PostgreSQL unspecified parameter data type

Posted by GitBox <gi...@apache.org>.

coveralls commented on pull request #6998:
URL: https://github.com/apache/shardingsphere/pull/6998#issuecomment-678655905


   ## Pull Request Test Coverage Report for [Build 14028](https://coveralls.io/builds/32931460)
   
   * **5** of **37**   **(13.51%)**  changed or added relevant lines in **6** files are covered.
   * No unchanged relevant lines lost coverage.
   * Overall coverage decreased (**-0.01%**) to **35.031%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/proxy/frontend/postgresql/PostgreSQLErrPacketFactory.java](https://coveralls.io/builds/32931460/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-frontend%2Fshardingsphere-proxy-frontend-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Ffrontend%2Fpostgresql%2FPostgreSQLErrPacketFactory.java#L48) | 5 | 8 | 62.5%
   | [shardingsphere-db-protocol/shardingsphere-db-protocol-postgresql/src/main/java/org/apache/shardingsphere/db/protocol/postgresql/packet/command/query/binary/bind/PostgreSQLComBindPacket.java](https://coveralls.io/builds/32931460/source?filename=shardingsphere-db-protocol%2Fshardingsphere-db-protocol-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fdb%2Fprotocol%2Fpostgresql%2Fpacket%2Fcommand%2Fquery%2Fbinary%2Fbind%2FPostgreSQLComBindPacket.java#L73) | 0 | 4 | 0.0%
   | [shardingsphere-db-protocol/shardingsphere-db-protocol-postgresql/src/main/java/org/apache/shardingsphere/db/protocol/postgresql/packet/command/query/binary/bind/PostgreSQLTypeUnspecifiedSQLParameter.java](https://coveralls.io/builds/32931460/source?filename=shardingsphere-db-protocol%2Fshardingsphere-db-protocol-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fdb%2Fprotocol%2Fpostgresql%2Fpacket%2Fcommand%2Fquery%2Fbinary%2Fbind%2FPostgreSQLTypeUnspecifiedSQLParameter.java#L29) | 0 | 4 | 0.0%
   | [shardingsphere-db-protocol/shardingsphere-db-protocol-postgresql/src/main/java/org/apache/shardingsphere/db/protocol/postgresql/packet/command/query/binary/bind/protocol/PostgreSQLBinaryProtocolValueFactory.java](https://coveralls.io/builds/32931460/source?filename=shardingsphere-db-protocol%2Fshardingsphere-db-protocol-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fdb%2Fprotocol%2Fpostgresql%2Fpacket%2Fcommand%2Fquery%2Fbinary%2Fbind%2Fprotocol%2FPostgreSQLBinaryProtocolValueFactory.java#L37) | 0 | 4 | 0.0%
   | [shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/connection/BackendConnection.java](https://coveralls.io/builds/32931460/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fconnection%2FBackendConnection.java#L209) | 0 | 4 | 0.0%
   | [shardingsphere-db-protocol/shardingsphere-db-protocol-postgresql/src/main/java/org/apache/shardingsphere/db/protocol/postgresql/packet/command/query/binary/bind/protocol/PostgreSQLUnspecifiedBinaryProtocolValue.java](https://coveralls.io/builds/32931460/source?filename=shardingsphere-db-protocol%2Fshardingsphere-db-protocol-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fdb%2Fprotocol%2Fpostgresql%2Fpacket%2Fcommand%2Fquery%2Fbinary%2Fbind%2Fprotocol%2FPostgreSQLUnspecifiedBinaryProtocolValue.java#L26) | 0 | 13 | 0.0%
   <!-- | **Total:** | **5** | **37** | **13.51%** | -->
   
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/32931460/badge)](https://coveralls.io/builds/32931460) |
   | :-- | --: |
   | Change from base [Build 14026](https://coveralls.io/builds/32929458): |  -0.01% |
   | Covered Lines: | 35197 |
   | Relevant Lines: | 100475 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tuohai666 commented on a change in pull request #6998: Fix #6579 : Support PostgreSQL unspecified parameter data type

Posted by GitBox <gi...@apache.org>.

tuohai666 commented on a change in pull request #6998:
URL: https://github.com/apache/shardingsphere/pull/6998#discussion_r476144782



##########
File path: shardingsphere-db-protocol/shardingsphere-db-protocol-postgresql/src/main/java/org/apache/shardingsphere/db/protocol/postgresql/packet/command/query/binary/bind/PostgreSQLTypeUnspecifiedSQLParameter.java
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.db.protocol.postgresql.packet.command.query.binary.bind;
+
+import org.apache.shardingsphere.db.protocol.parameter.TypeUnspecifiedSQLParameter;
+
+/**
+ * Type unspecified SQL parameter for PostgreSQL.
+ */
+public final class PostgreSQLTypeUnspecifiedSQLParameter implements TypeUnspecifiedSQLParameter {
+    
+    private final String parameterValue;
+    
+    public PostgreSQLTypeUnspecifiedSQLParameter(final String parameterValue) {
+        this.parameterValue = parameterValue;
+    }
+    
+    @Override
+    public String toString() {
+        // must be parameter value itself

Review comment:
       remove the comment




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] coveralls edited a comment on pull request #6998: Fix #6579 : Support PostgreSQL unspecified parameter data type

Posted by GitBox <gi...@apache.org>.

coveralls edited a comment on pull request #6998:
URL: https://github.com/apache/shardingsphere/pull/6998#issuecomment-678655905


   ## Pull Request Test Coverage Report for [Build 14034](https://coveralls.io/builds/32937207)
   
   * **21** of **32**   **(65.63%)**  changed or added relevant lines in **6** files are covered.
   * **49** unchanged lines in **7** files lost coverage.
   * Overall coverage increased (+**0.1%**) to **35.155%**
   
   ---
   
   |  Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
   | :-----|--------------|--------|---: |
   | [shardingsphere-proxy/shardingsphere-proxy-frontend/shardingsphere-proxy-frontend-postgresql/src/main/java/org/apache/shardingsphere/proxy/frontend/postgresql/PostgreSQLErrPacketFactory.java](https://coveralls.io/builds/32937207/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-frontend%2Fshardingsphere-proxy-frontend-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Ffrontend%2Fpostgresql%2FPostgreSQLErrPacketFactory.java#L48) | 5 | 8 | 62.5%
   | [shardingsphere-db-protocol/shardingsphere-db-protocol-postgresql/src/main/java/org/apache/shardingsphere/db/protocol/postgresql/packet/command/query/binary/bind/PostgreSQLComBindPacket.java](https://coveralls.io/builds/32937207/source?filename=shardingsphere-db-protocol%2Fshardingsphere-db-protocol-postgresql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fdb%2Fprotocol%2Fpostgresql%2Fpacket%2Fcommand%2Fquery%2Fbinary%2Fbind%2FPostgreSQLComBindPacket.java#L73) | 0 | 4 | 0.0%
   | [shardingsphere-proxy/shardingsphere-proxy-backend/src/main/java/org/apache/shardingsphere/proxy/backend/communication/jdbc/connection/BackendConnection.java](https://coveralls.io/builds/32937207/source?filename=shardingsphere-proxy%2Fshardingsphere-proxy-backend%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fproxy%2Fbackend%2Fcommunication%2Fjdbc%2Fconnection%2FBackendConnection.java#L209) | 0 | 4 | 0.0%
   <!-- | **Total:** | **21** | **32** | **65.63%** | -->
   
   |  Files with Coverage Reduction | New Missed Lines | % |
   | :-----|--------------|--: |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-binder/src/main/java/org/apache/shardingsphere/sql/parser/binder/statement/dml/CallStatementContext.java](https://coveralls.io/builds/32937207/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-binder%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fbinder%2Fstatement%2Fdml%2FCallStatementContext.java#L33) | 2 | 0% |
   | [shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/ShardingRouteDecorator.java](https://coveralls.io/builds/32937207/source?filename=shardingsphere-features%2Fshardingsphere-sharding%2Fshardingsphere-sharding-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2FShardingRouteDecorator.java#L86) | 4 | 93.33% |
   | [shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/validator/impl/ShardingDeleteStatementValidator.java](https://coveralls.io/builds/32937207/source?filename=shardingsphere-features%2Fshardingsphere-sharding%2Fshardingsphere-sharding-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2Fvalidator%2Fimpl%2FShardingDeleteStatementValidator.java#L41) | 4 | 42.86% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/DeleteStatement.java](https://coveralls.io/builds/32937207/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdml%2FDeleteStatement.java#L38) | 4 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-statement/src/main/java/org/apache/shardingsphere/sql/parser/sql/statement/dml/UpdateStatement.java](https://coveralls.io/builds/32937207/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-statement%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fsql%2Fstatement%2Fdml%2FUpdateStatement.java#L39) | 4 | 0% |
   | [shardingsphere-sql-parser/shardingsphere-sql-parser-dialect/shardingsphere-sql-parser-mysql/src/main/java/org/apache/shardingsphere/sql/parser/mysql/visitor/impl/MySQLDMLVisitor.java](https://coveralls.io/builds/32937207/source?filename=shardingsphere-sql-parser%2Fshardingsphere-sql-parser-dialect%2Fshardingsphere-sql-parser-mysql%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsql%2Fparser%2Fmysql%2Fvisitor%2Fimpl%2FMySQLDMLVisitor.java#L318) | 13 | 95.0% |
   | [shardingsphere-features/shardingsphere-sharding/shardingsphere-sharding-route/src/main/java/org/apache/shardingsphere/sharding/route/engine/validator/impl/ShardingUpdateStatementValidator.java](https://coveralls.io/builds/32937207/source?filename=shardingsphere-features%2Fshardingsphere-sharding%2Fshardingsphere-sharding-route%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fsharding%2Froute%2Fengine%2Fvalidator%2Fimpl%2FShardingUpdateStatementValidator.java#L75) | 18 | 55.56% |
   <!-- | **Total:** | **49** |  | -->
   
   |  Totals | [![Coverage Status](https://coveralls.io/builds/32937207/badge)](https://coveralls.io/builds/32937207) |
   | :-- | --: |
   | Change from base [Build 14026](https://coveralls.io/builds/32929458): |  0.1% |
   | Covered Lines: | 35328 |
   | Relevant Lines: | 100491 |
   
   ---
   ##### 💛  - [Coveralls](https://coveralls.io)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] tuohai666 merged pull request #6998: Fix #6579 : Support PostgreSQL unspecified parameter data type

Posted by GitBox <gi...@apache.org>.

tuohai666 merged pull request #6998:
URL: https://github.com/apache/shardingsphere/pull/6998


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org