You are viewing a plain text version of this content. The canonical link for it is here.
Posted to gitbox@activemq.apache.org by GitBox <gi...@apache.org> on 2020/04/08 02:47:16 UTC
[GitHub] [activemq-artemis] clebertsuconic opened a new pull request #3071:
ARTEMIS-2659 / ARTEMIS-2673 Fix AmqpSendReceiveTest.testAcceptWithoutSetting
clebertsuconic opened a new pull request #3071: ARTEMIS-2659 / ARTEMIS-2673 Fix AmqpSendReceiveTest.testAcceptWithoutSetting
URL: https://github.com/apache/activemq-artemis/pull/3071
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] asfgit merged pull request #3071: ARTEMIS-2659 /
ARTEMIS-2673 Fix AmqpSendReceiveTest.testAcceptWithoutSetting
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #3071: ARTEMIS-2659 / ARTEMIS-2673 Fix AmqpSendReceiveTest.testAcceptWithoutSetting
URL: https://github.com/apache/activemq-artemis/pull/3071
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] michaelpearce-gain commented on a change in pull
request #3071: ARTEMIS-2659 / ARTEMIS-2673 Fix
AmqpSendReceiveTest.testAcceptWithoutSetting
Posted by GitBox <gi...@apache.org>.
michaelpearce-gain commented on a change in pull request #3071: ARTEMIS-2659 / ARTEMIS-2673 Fix AmqpSendReceiveTest.testAcceptWithoutSetting
URL: https://github.com/apache/activemq-artemis/pull/3071#discussion_r405340196
##########
File path: artemis-protocols/artemis-amqp-protocol/src/main/java/org/apache/activemq/artemis/protocol/amqp/proton/ProtonServerSenderContext.java
##########
@@ -629,7 +629,16 @@ public void onMessage(Delivery delivery) throws ActiveMQAMQPException {
// this can happen in the twice ack mode, that is the receiver accepts and settles separately
// acking again would show an exception but would have no negative effect but best to handle anyway.
if (!delivery.isSettled()) {
- inSessionACK(delivery, message);
+ // we have to individual ack as we can't guarantee we will get the delivery updates
+ // (including acks) in order from dealer, a performance hit but a must
Review comment:
dealer ???
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [activemq-artemis] asfgit merged pull request #3071: ARTEMIS-2659 /
ARTEMIS-2673 Fix AmqpSendReceiveTest.testAcceptWithoutSetting
Posted by GitBox <gi...@apache.org>.
asfgit merged pull request #3071: ARTEMIS-2659 / ARTEMIS-2673 Fix AmqpSendReceiveTest.testAcceptWithoutSetting
URL: https://github.com/apache/activemq-artemis/pull/3071
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services