You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/11/02 18:19:47 UTC
[GitHub] [flink-kubernetes-operator] mbalassi opened a new pull request, #424: [FLINK-29655] Move FlinkResourceListener to api
mbalassi opened a new pull request, #424:
URL: https://github.com/apache/flink-kubernetes-operator/pull/424
I expect that this is finally the last commit for the API refactor change.
This is a potentially controversial one, because for this I needed to introduce an intentionally slim dependency on `flink-core`, this is why I ruled this out in the original PR #417. However on more thorough testing I realized that the listener interface is best exposed here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #424: [FLINK-29655] Move FlinkResourceListener to api
Posted by GitBox <gi...@apache.org>.
morhidi commented on PR #424:
URL: https://github.com/apache/flink-kubernetes-operator/pull/424#issuecomment-1301281774
LGTM, it seems we only needed the plugin interface from flink-core.
Nit: The STATUS generic type is not used. `public <STATUS extends CommonStatus<?>> ResourceLifecycleState getLifecycleState() {`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] mbalassi merged pull request #424: [FLINK-29655] Move FlinkResourceListener to api
Posted by GitBox <gi...@apache.org>.
mbalassi merged PR #424:
URL: https://github.com/apache/flink-kubernetes-operator/pull/424
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] mbalassi commented on pull request #424: [FLINK-29655] Move FlinkResourceListener to api
Posted by GitBox <gi...@apache.org>.
mbalassi commented on PR #424:
URL: https://github.com/apache/flink-kubernetes-operator/pull/424#issuecomment-1301291863
Thanks @morhidi, good catch. The beauty of refactoring.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-kubernetes-operator] mbalassi commented on pull request #424: [FLINK-29655] Move FlinkResourceListener to api
Posted by GitBox <gi...@apache.org>.
mbalassi commented on PR #424:
URL: https://github.com/apache/flink-kubernetes-operator/pull/424#issuecomment-1301044792
cc @morhidi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org