You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2020/06/08 02:44:04 UTC

[GitHub] [incubator-apisix] membphis commented on a change in pull request #1658: [bugfix] generate the 'worker_cpu_affinity' config

membphis commented on a change in pull request #1658:
URL: https://github.com/apache/incubator-apisix/pull/1658#discussion_r436434028



##########
File path: bin/apisix
##########
@@ -21,6 +21,8 @@ local function trim(s)
     return (s:gsub("^%s*(.-)%s*$", "%1"))
 end
 
+-- Note: The `excute_cmd` return value will have a line break at the end,
+-- it is recommended to use the `trim` function to handle the return value.

Review comment:
       we can move this comment to https://github.com/apache/incubator-apisix/pull/1658/files#diff-62edadffc237f13dc28a694080d293a8R670




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org