You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/09/03 21:42:47 UTC

[GitHub] [incubator-superset] codecov-io commented on issue #8165: [bugfix] fix timegrain addon regression

codecov-io commented on issue #8165: [bugfix] fix timegrain addon regression
URL: https://github.com/apache/incubator-superset/pull/8165#issuecomment-527652389
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8165?src=pr&el=h1) Report
   > Merging [#8165](https://codecov.io/gh/apache/incubator-superset/pull/8165?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/ee24539bd2dc0c66a204015ebcb957a924a55452?src=pr&el=desc) will **increase** coverage by `7.7%`.
   > The diff coverage is `100%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/8165/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/8165?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #8165      +/-   ##
   ==========================================
   + Coverage   66.06%   73.76%    +7.7%     
   ==========================================
     Files         479      115     -364     
     Lines       22930    12057   -10873     
     Branches     2524        0    -2524     
   ==========================================
   - Hits        15148     8894    -6254     
   + Misses       7648     3163    -4485     
   + Partials      134        0     -134
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/8165?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/db\_engine\_specs/bigquery.py](https://codecov.io/gh/apache/incubator-superset/pull/8165/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2JpZ3F1ZXJ5LnB5) | `52.23% <100%> (ø)` | :arrow_up: |
   | [superset/db\_engine\_specs/presto.py](https://codecov.io/gh/apache/incubator-superset/pull/8165/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3ByZXN0by5weQ==) | `77.8% <100%> (ø)` | :arrow_up: |
   | [superset/db\_engine\_specs/drill.py](https://codecov.io/gh/apache/incubator-superset/pull/8165/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RyaWxsLnB5) | `54.16% <100%> (ø)` | :arrow_up: |
   | [superset/db\_engine\_specs/kylin.py](https://codecov.io/gh/apache/incubator-superset/pull/8165/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2t5bGluLnB5) | `53.84% <100%> (ø)` | :arrow_up: |
   | [superset/db\_engine\_specs/db2.py](https://codecov.io/gh/apache/incubator-superset/pull/8165/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RiMi5weQ==) | `85.71% <100%> (ø)` | :arrow_up: |
   | [superset/db\_engine\_specs/teradata.py](https://codecov.io/gh/apache/incubator-superset/pull/8165/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3RlcmFkYXRhLnB5) | `88.88% <100%> (ø)` | :arrow_up: |
   | [superset/db\_engine\_specs/athena.py](https://codecov.io/gh/apache/incubator-superset/pull/8165/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2F0aGVuYS5weQ==) | `57.89% <100%> (ø)` | :arrow_up: |
   | [superset/db\_engine\_specs/druid.py](https://codecov.io/gh/apache/incubator-superset/pull/8165/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RydWlkLnB5) | `100% <100%> (ø)` | :arrow_up: |
   | [superset/db\_engine\_specs/impala.py](https://codecov.io/gh/apache/incubator-superset/pull/8165/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2ltcGFsYS5weQ==) | `65% <100%> (ø)` | :arrow_up: |
   | [superset/db\_engine\_specs/snowflake.py](https://codecov.io/gh/apache/incubator-superset/pull/8165/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Nub3dmbGFrZS5weQ==) | `59.09% <100%> (ø)` | :arrow_up: |
   | ... and [375 more](https://codecov.io/gh/apache/incubator-superset/pull/8165/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8165?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/8165?src=pr&el=footer). Last update [ee24539...2609c3b](https://codecov.io/gh/apache/incubator-superset/pull/8165?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org