You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/03/11 04:06:12 UTC

[GitHub] [incubator-mxnet] hzfan commented on a change in pull request #17789: [Numpy] FFI: diag/diagonal/diag_indices_from

hzfan commented on a change in pull request #17789: [Numpy] FFI: diag/diagonal/diag_indices_from
URL: https://github.com/apache/incubator-mxnet/pull/17789#discussion_r390735584
 
 

 ##########
 File path: src/api/operator/numpy/np_matrix_op.cc
 ##########
 @@ -43,6 +45,54 @@ MXNET_REGISTER_API("_npi.expand_dims")
   int num_outputs = 0;
   NDArray* inputs[] = {args[0].operator mxnet::NDArray*()};
   auto ndoutputs = Invoke(op, &attrs, 1, inputs, &num_outputs, nullptr);
+});
 
 Review comment:
   The `*ret = ndoutputs[0];` is missing in `_npi.expand_dims`. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services