Re: [PR] feat(Python-client):add dns resolution support [incubator-pegasus]

["empiredan (via GitHub)" <gi...@apache.org>]

empiredan commented on code in PR #2306:
URL: https://github.com/apache/incubator-pegasus/pull/2306#discussion_r2803044128


##########
python-client/pypegasus/base/ttypes.py:
##########
@@ -310,8 +310,8 @@ def __ne__(self, other):
 class host_port_types(Enum):
     kHostTypeInvalid = 0
     kHostTypeIpv4 = 1
-    kHostTypeGroup = 2
-
+    kHostTypeIpv6 = 2
+    kHostTypeGroup = 3

Review Comment:
   We'd better keep the value of kHostTypeGroup as it has been set to 2 by the server.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org