You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by GitBox <gi...@apache.org> on 2021/12/15 16:08:37 UTC

[GitHub] [curator] nicoloboschi opened a new pull request #404: CURATOR-624 Fix GitHub actions

nicoloboschi opened a new pull request #404:
URL: https://github.com/apache/curator/pull/404


   We need to specify the JDK distribution. I set the 'adopt' one


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [curator] nicoloboschi commented on pull request #404: CURATOR-624 Fix GitHub actions

Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #404:
URL: https://github.com/apache/curator/pull/404#issuecomment-1050688789


   no problem, we can merge the other one


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [curator] nicoloboschi closed pull request #404: CURATOR-624 Fix GitHub actions

Posted by GitBox <gi...@apache.org>.
nicoloboschi closed pull request #404:
URL: https://github.com/apache/curator/pull/404


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [curator] nicoloboschi commented on pull request #404: CURATOR-624 Fix GitHub actions

Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #404:
URL: https://github.com/apache/curator/pull/404#issuecomment-994936420


   closing to retrigger actions


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [curator] martin-g commented on pull request #404: CURATOR-624 Fix GitHub actions

Posted by GitBox <gi...@apache.org>.
martin-g commented on pull request #404:
URL: https://github.com/apache/curator/pull/404#issuecomment-1050685805


   I've just created https://github.com/apache/curator/pull/407 and now I noticed this PR.
   IMO mine is a bit better because of two reasons:
   * AdoptJDK has been donated to Eclipse Foundation and now its name is `Temurin`
   * I've merged the two workflows into one and used `strategy.matrix` to test with the different versions. This way it would be easier to test with more JDK versions, e.g. `17`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [curator] martin-g edited a comment on pull request #404: CURATOR-624 Fix GitHub actions

Posted by GitBox <gi...@apache.org>.
martin-g edited a comment on pull request #404:
URL: https://github.com/apache/curator/pull/404#issuecomment-1050685805


   I've just created https://github.com/apache/curator/pull/407 and now I noticed this PR.
   IMO mine is a bit better because of the following reasons:
   * AdoptJDK has been donated to Eclipse Foundation and now its name is `Temurin`
   * I've merged the two workflows into one and used `strategy.matrix` to test with the different versions. This way it would be easier to test with more JDK versions, e.g. `17`
   * added caching for Maven deps


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [curator] nicoloboschi closed pull request #404: CURATOR-624 Fix GitHub actions

Posted by GitBox <gi...@apache.org>.
nicoloboschi closed pull request #404:
URL: https://github.com/apache/curator/pull/404


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [curator] eolivelli commented on pull request #404: CURATOR-624 Fix GitHub actions

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #404:
URL: https://github.com/apache/curator/pull/404#issuecomment-1050687242


   thank you @nicoloboschi and @martin-g 
   
   I think @martin-g 's patch is better


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [curator] eolivelli commented on pull request #404: CURATOR-624 Fix GitHub actions

Posted by GitBox <gi...@apache.org>.
eolivelli commented on pull request #404:
URL: https://github.com/apache/curator/pull/404#issuecomment-1050687832


   @nicoloboschi I am sorry this patch became stale


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@curator.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org