You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2019/12/30 11:59:14 UTC

[GitHub] [rocketmq] wqliang opened a new issue #1689: StatsItem not remove after group or topic be removed

wqliang opened a new issue #1689: StatsItem not remove after group or topic be removed
URL: https://github.com/apache/rocketmq/issues/1689
 
 
   **BUG REPORT**
   
   1. Please describe the issue you observed:
   BrokerStatsThread at broker side will make some statistic on group level and topic level. After a subscription group or topic be removed, the corresponding stats item not be removed untill broker restart. 
   I need to create new group frequently and each group will be removed after finish it's sonsumption task. 
   
   The StatsItem of nonexistent group would never be removed which may cause oom.
   
   I have already add such interface and remove StatsItem when group or topic be removed. 
   
   Maybe create and remove a group frequently is not a good idea, but can BrokerStatsManager provide a interface to remove unused statsItem?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] zongtanghu closed issue #1689: StatsItem not remove after group or topic be removed

Posted by GitBox <gi...@apache.org>.
zongtanghu closed issue #1689: StatsItem not remove after group or topic be removed
URL: https://github.com/apache/rocketmq/issues/1689
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] zongtanghu edited a comment on issue #1689: StatsItem not remove after group or topic be removed

Posted by GitBox <gi...@apache.org>.
zongtanghu edited a comment on issue #1689: StatsItem not remove after group or topic be removed
URL: https://github.com/apache/rocketmq/issues/1689#issuecomment-571044717
 
 
   it's yours @fortrueme

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] wqliang opened a new issue #1689: StatsItem not remove after group or topic be removed

Posted by GitBox <gi...@apache.org>.
wqliang opened a new issue #1689: StatsItem not remove after group or topic be removed
URL: https://github.com/apache/rocketmq/issues/1689
 
 
   **BUG REPORT**
   
   1. Please describe the issue you observed:
   BrokerStatsThread at broker side will make some statistic on group level and topic level. After a subscription group or topic be removed, the corresponding stats item not be removed untill broker restart. 
   I need to create new group frequently and each group will be removed after finish it's sonsumption task. 
   
   The StatsItem of nonexistent group would never be removed which may cause oom.
   
   I have already add such interface and remove StatsItem when group or topic be removed. 
   
   Maybe create and remove a group frequently is not a good idea, but can BrokerStatsManager provide a interface to remove unused statsItem?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] zongtanghu commented on issue #1689: StatsItem not remove after group or topic be removed

Posted by GitBox <gi...@apache.org>.
zongtanghu commented on issue #1689: StatsItem not remove after group or topic be removed
URL: https://github.com/apache/rocketmq/issues/1689#issuecomment-571044834
 
 
   > @fortrueme
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] zongtanghu commented on issue #1689: StatsItem not remove after group or topic be removed

Posted by GitBox <gi...@apache.org>.
zongtanghu commented on issue #1689: StatsItem not remove after group or topic be removed
URL: https://github.com/apache/rocketmq/issues/1689#issuecomment-571044717
 
 
   @fortrueme

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [rocketmq] zongtanghu commented on issue #1689: StatsItem not remove after group or topic be removed

Posted by GitBox <gi...@apache.org>.
zongtanghu commented on issue #1689: StatsItem not remove after group or topic be removed
URL: https://github.com/apache/rocketmq/issues/1689#issuecomment-571043882
 
 
   This issue we can put forward a pr for this enhancement.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services