You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2021/09/09 05:21:42 UTC
[GitHub] [incubator-doris] WindyGao opened a new pull request #6593: add doc for storage_root_path
WindyGao opened a new pull request #6593:
URL: https://github.com/apache/incubator-doris/pull/6593
## Proposed changes
Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.
## Types of changes
What types of changes does your code introduce to Doris?
_Put an `x` in the boxes that apply_
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New feature (non-breaking change which adds functionality)
- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
- [ ] Documentation Update (if none of the other choices apply)
- [ ] Code refactor (Modify the code structure, format the code, etc...)
- [ ] Optimization. Including functional usability improvements and performance improvements.
- [ ] Dependency. Such as changes related to third-party components.
- [ ] Other.
## Checklist
_Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._
- [ ] I have created an issue on (Fix #ISSUE) and described the bug/feature there in detail
- [ ] Compiling and unit tests pass locally with my changes
- [ ] I have added tests that prove my fix is effective or that my feature works
- [ ] If these changes need document changes, I have updated the document
- [ ] Any dependent changes have been merged
## Further comments
If this is a relatively large or complex change, kick off the discussion at dev@doris.apache.org by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] WindyGao commented on a change in pull request #6593: add doc for storage_root_path
Posted by GitBox <gi...@apache.org>.
WindyGao commented on a change in pull request #6593:
URL: https://github.com/apache/incubator-doris/pull/6593#discussion_r704979475
##########
File path: docs/zh-CN/administrator-guide/config/be_config.md
##########
@@ -1141,15 +1141,27 @@ storage_flood_stage_usage_percent和storage_flood_stage_left_capacity_bytes两
* 描述：BE数据存储的目录,多目录之间用英文状态的分号`;`分隔。可以通过路径区别存储目录的介质，HDD或SSD。可以添加容量限制在每个路径的末尾，通过英文状态逗号`,`隔开。
+ 示例1如下：
+
**注意：如果是SSD磁盘要在目录后面加上`.SSD`,HDD磁盘在目录后面加`.HDD`**
- 示例如下：
-
`storage_root_path=/home/disk1/doris.HDD,50;/home/disk2/doris.SSD,10;/home/disk2/doris`
* /home/disk1/doris.HDD, 50，表示存储限制为50GB, HDD;
* /home/disk2/doris.SSD 10， 存储限制为10GB，SSD；
* /home/disk2/doris，存储限制为磁盘最大容量，默认为HDD
+
+ 示例2如下：
+
Review comment:
Ok, Let me expand the English doc. It was inconsistent before I saw the document
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] yangzhg merged pull request #6593: add doc for storage_root_path
Posted by GitBox <gi...@apache.org>.
yangzhg merged pull request #6593:
URL: https://github.com/apache/incubator-doris/pull/6593
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] WindyGao commented on pull request #6593: add doc for storage_root_path
Posted by GitBox <gi...@apache.org>.
WindyGao commented on pull request #6593:
URL: https://github.com/apache/incubator-doris/pull/6593#issuecomment-915777234
> you should add english doc for install-deploy.md at the same time
okey
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] caiconghui commented on a change in pull request #6593: add doc for storage_root_path
Posted by GitBox <gi...@apache.org>.
caiconghui commented on a change in pull request #6593:
URL: https://github.com/apache/incubator-doris/pull/6593#discussion_r704968264
##########
File path: docs/zh-CN/administrator-guide/config/be_config.md
##########
@@ -1141,15 +1141,27 @@ storage_flood_stage_usage_percent和storage_flood_stage_left_capacity_bytes两
* 描述：BE数据存储的目录,多目录之间用英文状态的分号`;`分隔。可以通过路径区别存储目录的介质，HDD或SSD。可以添加容量限制在每个路径的末尾，通过英文状态逗号`,`隔开。
+ 示例1如下：
+
**注意：如果是SSD磁盘要在目录后面加上`.SSD`,HDD磁盘在目录后面加`.HDD`**
- 示例如下：
-
`storage_root_path=/home/disk1/doris.HDD,50;/home/disk2/doris.SSD,10;/home/disk2/doris`
* /home/disk1/doris.HDD, 50，表示存储限制为50GB, HDD;
* /home/disk2/doris.SSD 10， 存储限制为10GB，SSD；
* /home/disk2/doris，存储限制为磁盘最大容量，默认为HDD
+
+ 示例2如下：
+
Review comment:
chinese doc should keep consistent with english doc
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] github-actions[bot] commented on pull request #6593: add doc for storage_root_path
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #6593:
URL: https://github.com/apache/incubator-doris/pull/6593#issuecomment-915804882
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org