You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/05/28 01:36:48 UTC

[GitHub] [airflow] Taragolis opened a new pull request, #23976: fix: StepFunctionHook ignores explicit set `region_name`

Taragolis opened a new pull request, #23976:
URL: https://github.com/apache/airflow/pull/23976

   Parameter `region_name` in `airflow.providers.amazon.aws.hooks.step_function.StepFunctionHook` doesn't do anything, and doesn't propagate to parent AwsBaseHook
   
   **Sample**
   ```python
   import os
   from airflow.providers.amazon.aws.hooks.step_function import StepFunctionHook
   
   os.environ["AIRFLOW_CONN_TEST_CONN"] = "aws://?region_name=eu-west-1"
   
   hook = StepFunctionHook(aws_conn_id="test_conn")
   conn = hook.conn
   assert conn.meta.region_name == "eu-west-1"
   
   hook = StepFunctionHook(aws_conn_id="test_conn", region_name="ap-southeast-2")
   conn = hook.conn
   assert conn.meta.region_name == "ap-southeast-2"
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] josh-fell merged pull request #23976: fix: StepFunctionHook ignores explicit set `region_name`

Posted by GitBox <gi...@apache.org>.
josh-fell merged PR #23976:
URL: https://github.com/apache/airflow/pull/23976


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] github-actions[bot] commented on pull request #23976: fix: StepFunctionHook ignores explicit set `region_name`

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #23976:
URL: https://github.com/apache/airflow/pull/23976#issuecomment-1140190331

   The PR is likely OK to be merged with just subset of tests for default Python and Database versions without running the full matrix of tests, because it does not modify the core of Airflow. If the committers decide that the full tests matrix is needed, they will add the label 'full tests needed'. Then you should rebase to the latest main or amend the last commit of the PR, and push it with --force-with-lease.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org