[GitHub] [pinot] wirybeaver commented on a diff in pull request #10758: Add a new controller endpoint for segment deletion with a time window

["wirybeaver (via GitHub)" <gi...@apache.org>]

wirybeaver commented on code in PR #10758:
URL: https://github.com/apache/pinot/pull/10758#discussion_r1253455169


##########
pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentRestletResource.java:
##########
@@ -884,6 +865,52 @@ public SuccessResponse deleteSegments(
     }
   }
 
+  @DELETE
+  @Consumes(MediaType.APPLICATION_JSON)
+  @Produces(MediaType.APPLICATION_JSON)
+  @Path("/segments/{tableName}/select")

Review Comment:
   @snleee I actually copy the parameters from `GET /segments/{tableName}`, and enforce `GET /segments/{tableName}` and this delete function use the same private method selectSegments. It's just a coincidence that the path overlap with the deprecated `GET /segments/{tableName}/select`. I can rename the path to `DELETE /segments/{tableName}/choose`.
   
   The `DELETE /segments/{tableName}` has annotation `@ApiOperation(value = "Delete all segments", notes = "Delete all segments")`, that's the reason why I want to have a different path.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org