You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "stack (JIRA)" <ji...@apache.org> on 2012/11/08 07:48:12 UTC
[jira] [Commented] (HBASE-4913) Per-CF compaction Via the Shell
[ https://issues.apache.org/jira/browse/HBASE-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13493003#comment-13493003 ]
stack commented on HBASE-4913:
------------------------------
In the below:
{code}
if (major) {
- region.triggerMajorCompaction();
+ if (family != null) {
+ store.triggerMajorCompaction();
+ } else {
+ region.triggerMajorCompaction();
+ }
}
- LOG.trace("User-triggered compaction requested for region " +
- region.getRegionNameAsString());
- compactSplitThread.requestCompaction(region,
- "User-triggered " + (major ? "major " : "") + "compaction",
+
+ String log = "User-triggered " + (major ? "major " : "") + "compaction";
+ if(family != null) {
+ compactSplitThread.requestCompaction(region, store, log,
+ Store.PRIORITY_USER);
+ } else {
+ compactSplitThread.requestCompaction(region, log,
Store.PRIORITY_USER);
+ }
{code}
If a major compaction, should we break after its triggered instead of falling into the next block which seems to be queuing a compaction?
Else patch looks good to me.
> Per-CF compaction Via the Shell
> -------------------------------
>
> Key: HBASE-4913
> URL: https://issues.apache.org/jira/browse/HBASE-4913
> Project: HBase
> Issue Type: Sub-task
> Components: Client, regionserver
> Reporter: Nicolas Spiegelberg
> Assignee: Mubarak Seyed
> Fix For: 0.96.0
>
> Attachments: HBASE-4913.trunk.v1.patch, HBASE-4913.trunk.v2.patch, HBASE-4913.trunk.v2.patch, HBASE-4913-trunk-v3.patch
>
>
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira