[GitHub] [spark] MaxGekk commented on a diff in pull request #41865: [SPARK-44268][CORE][TEST][FOLLOWUP] Add test to generate `sql-error-conditions` doc automatic

["MaxGekk (via GitHub)" <gi...@apache.org>]

MaxGekk commented on code in PR #41865:
URL: https://github.com/apache/spark/pull/41865#discussion_r1253523590


##########
docs/sql-error-conditions-datatype-mismatch-error-class.md:
##########
@@ -176,16 +174,13 @@ A range window frame cannot be used in an unordered window specification.
 ## SEQUENCE_WRONG_INPUT_TYPES
 
 `<functionName>` uses the wrong parameter type. The parameter type must conform to:
-
 1. The start and stop expressions must resolve to the same type.
-
 2. If start and stop expressions resolve to the `<startType>` type, then the step expression must resolve to the `<stepType>` type.
-
 3. Otherwise, if start and stop expressions resolve to the `<otherStartType>` type, then the step expression must resolve to the same type.
 
 ## SPECIFIED_WINDOW_FRAME_DIFF_TYPES
 
-Window frame bounds `<lower>` and `<upper>` do not have the same type: `<lowerType>` <> `<upperType>`.
+Window frame bounds `<lower>` and `<upper>` do not have the same type: `<lowerType>` `<>` `<upperType>`.

Review Comment:
   Should leave <> as is?



##########
docs/sql-error-conditions-invalid-parameter-value-error-class.md:
##########
@@ -51,6 +51,6 @@ Expects group index between 0 and `<groupCount>`, but got `<groupIndex>`.
 
 ## ZERO_INDEX
 
-expects `%1$`, `%2$` and so on, but got `%0$`.
+expects %1$, %2$ and so on, but got %0$.

Review Comment:
   This one should have quotes, shouldn't it?



##########
docs/sql-error-conditions-incomplete-type-definition-error-class.md:
##########
@@ -31,10 +31,10 @@ The definition of "ARRAY" type is incomplete. You must provide an element type.
 
 ## MAP
 
-The definition of "MAP" type is incomplete. You must provide a key type and a value type. For example: "MAP<TIMESTAMP, INT>".
+The definition of "MAP" type is incomplete. You must provide a key type and a value type. For example: "MAP`<TIMESTAMP, INT>`".

Review Comment:
   Similar issue here, don't quote <TIMESTAMP, INT>



##########
docs/sql-error-conditions-datatype-mismatch-error-class.md:
##########
@@ -205,7 +200,7 @@ The lower bound of a window frame must be `<comparison>` to the upper bound.
 
 ## STACK_COLUMN_DIFF_TYPES
 
-The data type of the column (`<columnIndex>`) do not have the same type: `<leftType>` (`<leftParamIndex>`) <> `<rightType>` (`<rightParamIndex>`).
+The data type of the column (`<columnIndex>`) do not have the same type: `<leftType>` (`<leftParamIndex>`) `<>` `<rightType>` (`<rightParamIndex>`).

Review Comment:
   ditto: don't touch <>



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org