You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by jo...@apache.org on 2004/09/30 12:23:35 UTC

cvs commit: apache-1.3/src/main http_core.c

jorton      2004/09/30 03:23:35

  Modified:    src      CHANGES
               src/main http_core.c
  Log:
  * src/main/http_core.c (ap_auth_nonce): Fix default nonce string to
  use the socket address, rather than the address of a pointer into r->,
  which changes for each connection and hence forces re-authentication
  for every new connection since 1.3.31.
  
  PR: 30920
  
  Revision  Changes    Path
  1.1955    +4 -0      apache-1.3/src/CHANGES
  
  Index: CHANGES
  ===================================================================
  RCS file: /home/cvs/apache-1.3/src/CHANGES,v
  retrieving revision 1.1954
  retrieving revision 1.1955
  diff -d -w -u -r1.1954 -r1.1955
  --- CHANGES	8 Sep 2004 13:35:12 -0000	1.1954
  +++ CHANGES	30 Sep 2004 10:23:34 -0000	1.1955
  @@ -1,5 +1,9 @@
   Changes with Apache 1.3.32
   
  +  *) mod_digest: Fix nonce string calculation since 1.3.31 which
  +     would force re-authentication for every connection if
  +     AuthDigestRealmSeed was not configure.  PR 30920.  [Joe Orton]
  +
     *) Trigger an error when a LoadModule directive attempts to
        load a module which is built-in.  This is a common error when
        switching from a DSO build to a static build.
  
  
  
  1.338     +2 -2      apache-1.3/src/main/http_core.c
  
  Index: http_core.c
  ===================================================================
  RCS file: /home/cvs/apache-1.3/src/main/http_core.c,v
  retrieving revision 1.337
  retrieving revision 1.338
  diff -d -w -u -r1.337 -r1.338
  --- http_core.c	2 Jun 2004 22:49:03 -0000	1.337
  +++ http_core.c	30 Sep 2004 10:23:35 -0000	1.338
  @@ -563,8 +563,8 @@
        * But then again - you should use AuthDigestRealmSeed in your config
        * file if you care. So the adhoc value should do.
        */
  -    return ap_psprintf(r->pool,"%pp%pp%pp%pp%pp",
  -           (void *)&((r->connection->local_addr).sin_addr ),
  +    return ap_psprintf(r->pool,"%pI%pp%pp%pp%pp",
  +           &r->connection->local_addr.sin_addr,
              (void *)ap_user_name,
              (void *)ap_listeners,
              (void *)ap_server_argv0,