You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by mateiz <gi...@git.apache.org> on 2014/07/11 22:56:18 UTC

[GitHub] spark pull request: [PySpark] hijack hash to make hash of None con...

Github user mateiz commented on the pull request:

    https://github.com/apache/spark/pull/1371#issuecomment-48782037
  
    This was already fixed before in another way -- see the code at line 1061 of rdd.py:
    ```
            if partitionFunc is None:
                partitionFunc = lambda x: 0 if x is None else hash(x)
    ```
    I much prefer this to replacing the global "hash" function. Just do the same fix elsewhere if there are places where it's a problem.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---