[GitHub] [incubator-kyuubi] pan3793 commented on a diff in pull request #3175: Add session conf advisor docs

[GitBox <gi...@apache.org>]

pan3793 commented on code in PR #3175:
URL: https://github.com/apache/incubator-kyuubi/pull/3175#discussion_r935094632


##########
docs/extensions/server/configuration.rst:
##########
@@ -20,5 +20,41 @@ Inject Session Conf with Custom Config Advisor
 
 .. caution:: unstable
 
-.. warning::
-   This page is still in-progress.
+The step inject session conf with custom config advisor
+-------------------
+
+1. create a custom class which implements the `org.apache.kyuubi.plugin.SessionConfAdvisor`.
+2. adding configuration at `kyuubi-defaults.conf`:
+   ```
+   kyuubi.session.conf.advisor=${classname}
+   ```
+3. Compile and put the jar into `KYUUBI_HOME/jars`

Review Comment:
   missing $ ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org