You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "Liyixin95 (via GitHub)" <gi...@apache.org> on 2025/05/08 13:03:18 UTC

[PR] read and write duration type [arrow-rs]

Liyixin95 opened a new pull request, #7482:
URL: https://github.com/apache/arrow-rs/pull/7482

   continue from [previous pr](https://github.com/apache/arrow-rs/pull/5626#issuecomment-2862612245). @alamb 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Support round trip reading / writing Arrow `Duration` type to parquet [arrow-rs]

Posted by "Liyixin95 (via GitHub)" <gi...@apache.org>.
Liyixin95 commented on PR #7482:
URL: https://github.com/apache/arrow-rs/pull/7482#issuecomment-2864799560

   > @alamb  I poked around and actually found that there were some pre-existing tests 
   
   Oh, Thanks. I didn't notice there were some pre-existing tests. I just create the pr and go to sleep.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Support round trip reading / writing Arrow `Duration` type to parquet [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #7482:
URL: https://github.com/apache/arrow-rs/pull/7482


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] read and write duration type [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #7482:
URL: https://github.com/apache/arrow-rs/pull/7482#discussion_r2080183694


##########
parquet/src/arrow/arrow_writer/mod.rs:
##########
@@ -2471,25 +2471,21 @@ mod tests {
     }
 
     #[test]
-    #[should_panic(expected = "Converting Duration to parquet not supported")]
     fn duration_second_single_column() {

Review Comment:
   I found there were already existing tests for the feature ❤️  (thanks @carols10cents )



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Support round trip reading / writing Arrow `Duration` type to parquet [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #7482:
URL: https://github.com/apache/arrow-rs/pull/7482#issuecomment-2867281922

   > > @alamb  I poked around and actually found that there were some pre-existing tests
   > 
   > Oh, Thanks. I didn't notice there were some pre-existing tests. I just create the pr and go to sleep.
   
   I didn't realize there were any tests either until I checked out the branch locally and they failed for me 😆 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] read and write duration type [arrow-rs]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #7482:
URL: https://github.com/apache/arrow-rs/pull/7482#issuecomment-2863799442

   CI Failure should be fixed by @crepererum 's PR:
   - https://github.com/apache/arrow-rs/pull/7483


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org