You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cxf.apache.org by GitBox <gi...@apache.org> on 2020/09/22 21:29:53 UTC
[GitHub] [cxf] andymc12 opened a new pull request #698: [CXF-8347] URI processing/caching/extending changes
andymc12 opened a new pull request #698:
URL: https://github.com/apache/cxf/pull/698
Includes:
- URITemplate cache
- Extension to allow extenders to wrap runnables from HTTPConduit
- Numeric handling in URIs
- URITemplate processes parameters
- Add checking for form post when content-type includes charsets, etc.
These are part of the changes made in the Open Liberty "fork" of CXF.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] andymc12 commented on pull request #698: [CXF-8347] URI processing/caching/extending changes
Posted by GitBox <gi...@apache.org>.
andymc12 commented on pull request #698:
URL: https://github.com/apache/cxf/pull/698#issuecomment-702311356
Rebased from master - was hoping that the force-push would kick off an integration build, but it doesn't seem to have...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] coheigea commented on pull request #698: [CXF-8347] URI processing/caching/extending changes
Posted by GitBox <gi...@apache.org>.
coheigea commented on pull request #698:
URL: https://github.com/apache/cxf/pull/698#issuecomment-702535049
@reta I think so - what do I need to change?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] coheigea commented on pull request #698: [CXF-8347] URI processing/caching/extending changes
Posted by GitBox <gi...@apache.org>.
coheigea commented on pull request #698:
URL: https://github.com/apache/cxf/pull/698#issuecomment-702729299
@reta For which CXF build on ci-builds should I make those changes in?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta commented on pull request #698: [CXF-8347] URI processing/caching/extending changes
Posted by GitBox <gi...@apache.org>.
reta commented on pull request #698:
URL: https://github.com/apache/cxf/pull/698#issuecomment-702721108
>
>
> @reta I think so - what do I need to change?
thanks @coheigea , there are instructions on wiki: https://cwiki.apache.org/confluence/display/INFRA/Kicking+off+a+Jenkins+build+with+a+GitHub+PR (please feel free to ping me in private if you need any help). It seems like `builds.apache.org` now redirects to `ci-builds.apache.org`, we probably just need to make sure that webhooks work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta commented on pull request #698: [CXF-8347] URI processing/caching/extending changes
Posted by GitBox <gi...@apache.org>.
reta commented on pull request #698:
URL: https://github.com/apache/cxf/pull/698#issuecomment-702789543
>
>
> @reta For which CXF build on ci-builds should I make those changes in?
https://ci-builds.apache.org/job/CXF/job/CXF-JDK8/, this is out standard one, we could extend it to others later one
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta commented on pull request #698: [CXF-8347] URI processing/caching/extending changes
Posted by GitBox <gi...@apache.org>.
reta commented on pull request #698:
URL: https://github.com/apache/cxf/pull/698#issuecomment-702338787
Sorry @andymc12, I haven't had time to review this PR yet (not forgotten), will do that shortly. The integration builds are not triggering right now since the CI server has changed the name (builds.apache.org -> ci-builds.apache.org), I don't have permissions to modify the repository settings to change webhook endpoints, @dkulp / @coheigea do you have admin rights, guys?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta edited a comment on pull request #698: [CXF-8347] URI processing/caching/extending changes
Posted by GitBox <gi...@apache.org>.
reta edited a comment on pull request #698:
URL: https://github.com/apache/cxf/pull/698#issuecomment-702789543
>
>
> @reta For which CXF build on ci-builds should I make those changes in?
@coheigea https://ci-builds.apache.org/job/CXF/job/CXF-JDK8/, this is out standard one, we could extend it to others later one
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta commented on pull request #698: [CXF-8347] URI processing/caching/extending changes
Posted by GitBox <gi...@apache.org>.
reta commented on pull request #698:
URL: https://github.com/apache/cxf/pull/698#issuecomment-702802689
@coheigea done, https://ci-builds.apache.org/job/CXF/job/CXF-JDK8-PR/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] andymc12 commented on pull request #698: [CXF-8347] URI processing/caching/extending changes
Posted by GitBox <gi...@apache.org>.
andymc12 commented on pull request #698:
URL: https://github.com/apache/cxf/pull/698#issuecomment-702468584
@reta - no worries - it's a fairly big change, so I wasn't expecting instant turnaround. :) Please let me know if you have any questions on these changes. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] coheigea edited a comment on pull request #698: [CXF-8347] URI processing/caching/extending changes
Posted by GitBox <gi...@apache.org>.
coheigea edited a comment on pull request #698:
URL: https://github.com/apache/cxf/pull/698#issuecomment-702800627
Yes please do, I've actually made the change already to "Check "Enable Git validated merge support" and "Build pull requests to the repository" in your build config". Not sure if the other changes are required? Once you copy the changes, I'll revert the changes on the original job...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] reta commented on pull request #698: [CXF-8347] URI processing/caching/extending changes
Posted by GitBox <gi...@apache.org>.
reta commented on pull request #698:
URL: https://github.com/apache/cxf/pull/698#issuecomment-702798069
@coheigea sorry, just realized we had a dedicated build previously just for PRs, I could clone https://ci-builds.apache.org/job/CXF/job/CXF-JDK8/, and name it like https://ci-builds.apache.org/job/CXF/job/CXF-JDK8-PR/, would be good for you?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cxf] coheigea commented on pull request #698: [CXF-8347] URI processing/caching/extending changes
Posted by GitBox <gi...@apache.org>.
coheigea commented on pull request #698:
URL: https://github.com/apache/cxf/pull/698#issuecomment-702800627
Yes please do, I've actually made the change already to "Check "Enable Git validated merge support" and "Build pull requests to the repository" in your build config". Not sure if the other changes are required?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org