You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@yunikorn.apache.org by GitBox <gi...@apache.org> on 2022/03/09 20:49:11 UTC

[GitHub] [incubator-yunikorn-release] craigcondit commented on a change in pull request #83: [YUNIKORN-638] Make placeholder image configurable

craigcondit commented on a change in pull request #83:
URL: https://github.com/apache/incubator-yunikorn-release/pull/83#discussion_r823076006



##########
File path: helm-charts/yunikorn/templates/deployment.yaml
##########
@@ -83,6 +83,10 @@ spec:
               value: "{{ .Values.UserLabelKey }}"
             - name: OPERATOR_PLUGINS
               value: "{{ .Values.operatorPlugins }}"
+            {{- if .Values.placeholderImage }}

Review comment:
       I agree, this is cleaner.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@yunikorn.apache.org
For additional commands, e-mail: dev-help@yunikorn.apache.org