[jira] [Work logged] (GOBBLIN-1473) Fix ConcurrentModificationException when handling leadership change

["ASF GitHub Bot (Jira)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/GOBBLIN-1473?focusedWorklogId=611024&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-611024 ]

ASF GitHub Bot logged work on GOBBLIN-1473:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 14/Jun/21 23:43
            Start Date: 14/Jun/21 23:43
    Worklog Time Spent: 10m 
      Work Description: jack-moseley opened a new pull request #3312:
URL: https://github.com/apache/gobblin/pull/3312


   Dear Gobblin maintainers,
   
   Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below!
   
   
   ### JIRA
   - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
       - https://issues.apache.org/jira/browse/GOBBLIN-1473
   
   
   ### Description
   - [x] Here are some details about my PR, including screenshots (if applicable):
   Prevously, `ConcurrentModificationException` could happen when switching from active to inactive in the scheduler, because specs were removed from `scheduledFlowSpecs` while iterating through it. This fixes it in this scenario by not removing during iteration and just clearing the map at the end (since every entry should get removed anyway).
   
   ### Tests
   - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   
   ### Commits
   - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
       1. Subject is separated from body by a blank line
       2. Subject is limited to 50 characters
       3. Subject does not end with a period
       4. Subject uses the imperative mood ("add", not "adding")
       5. Body wraps at 72 characters
       6. Body explains "what" and "why", not "how"
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 611024)
    Remaining Estimate: 0h
            Time Spent: 10m

> Fix ConcurrentModificationException when handling leadership change
> -------------------------------------------------------------------
>
>                 Key: GOBBLIN-1473
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-1473
>             Project: Apache Gobblin
>          Issue Type: Bug
>            Reporter: Jack Moseley
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)