You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2021/08/01 03:09:55 UTC
[GitHub] [incubator-eventmesh] ruanwenjun opened a new pull request #479: [ISSUE #473]fix configuration property get error
ruanwenjun opened a new pull request #479:
URL: https://github.com/apache/incubator-eventmesh/pull/479
fix the configuration check error
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on a change in pull request #479: [ISSUE #473]fix configuration property get error
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #479:
URL: https://github.com/apache/incubator-eventmesh/pull/479#discussion_r680624659
##########
File path: eventmesh-common/src/main/java/org/apache/eventmesh/common/config/ConfigurationWrapper.java
##########
@@ -80,7 +80,7 @@ public int getIntProp(String configKey, int defaultValue) {
if (StringUtils.isEmpty(configValue)) {
return defaultValue;
}
- Preconditions.checkState(StringUtils.isNumeric(configKey), String.format("%s error", configKey));
+ Preconditions.checkState(StringUtils.isNumeric(configValue), String.format("%s error", configKey));
Review comment:
Yes, do we need to use configValue?
or use `String.format("key:%s value:%s error", configKey, configValue)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] ruanwenjun commented on a change in pull request #479: [ISSUE #473]fix configuration property get error
Posted by GitBox <gi...@apache.org>.
ruanwenjun commented on a change in pull request #479:
URL: https://github.com/apache/incubator-eventmesh/pull/479#discussion_r680886920
##########
File path: eventmesh-common/src/main/java/org/apache/eventmesh/common/config/ConfigurationWrapper.java
##########
@@ -80,7 +80,7 @@ public int getIntProp(String configKey, int defaultValue) {
if (StringUtils.isEmpty(configValue)) {
return defaultValue;
}
- Preconditions.checkState(StringUtils.isNumeric(configKey), String.format("%s error", configKey));
+ Preconditions.checkState(StringUtils.isNumeric(configValue), String.format("%s error", configKey));
Review comment:
Done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on a change in pull request #479: [ISSUE #473]fix configuration property get error
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on a change in pull request #479:
URL: https://github.com/apache/incubator-eventmesh/pull/479#discussion_r680619750
##########
File path: eventmesh-common/src/main/java/org/apache/eventmesh/common/config/ConfigurationWrapper.java
##########
@@ -80,7 +80,7 @@ public int getIntProp(String configKey, int defaultValue) {
if (StringUtils.isEmpty(configValue)) {
return defaultValue;
}
- Preconditions.checkState(StringUtils.isNumeric(configKey), String.format("%s error", configKey));
+ Preconditions.checkState(StringUtils.isNumeric(configValue), String.format("%s error", configKey));
Review comment:
here String.format is still configKey?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 merged pull request #479: [ISSUE #473]fix configuration property get error
Posted by GitBox <gi...@apache.org>.
xwm1992 merged pull request #479:
URL: https://github.com/apache/incubator-eventmesh/pull/479
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov-commenter commented on pull request #479: [ISSUE #473]fix configuration property get error
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #479:
URL: https://github.com/apache/incubator-eventmesh/pull/479#issuecomment-890441096
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/479?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#479](https://codecov.io/gh/apache/incubator-eventmesh/pull/479?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5c893f8) into [develop](https://codecov.io/gh/apache/incubator-eventmesh/commit/0e4def2cc9ea25be504f65f9a7f7e860764c9777?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0e4def2) will **not change** coverage.
> The diff coverage is `0.00%`.
> :exclamation: Current head 5c893f8 differs from pull request most recent head aaa65c3. Consider uploading reports for the commit aaa65c3 to get more accurate results
[](https://codecov.io/gh/apache/incubator-eventmesh/pull/479?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #479 +/- ##
==========================================
Coverage 11.25% 11.25%
Complexity 326 326
==========================================
Files 228 228
Lines 10796 10796
Branches 907 907
==========================================
Hits 1215 1215
Misses 9484 9484
Partials 97 97
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/479?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../eventmesh/common/config/ConfigurationWrapper.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/479/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9jb25maWcvQ29uZmlndXJhdGlvbldyYXBwZXIuamF2YQ==) | `48.38% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/479?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/479?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0e4def2...aaa65c3](https://codecov.io/gh/apache/incubator-eventmesh/pull/479?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] codecov-commenter edited a comment on pull request #479: [ISSUE #473]fix configuration property get error
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #479:
URL: https://github.com/apache/incubator-eventmesh/pull/479#issuecomment-890441096
# [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/479?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#479](https://codecov.io/gh/apache/incubator-eventmesh/pull/479?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (bfaa9c4) into [develop](https://codecov.io/gh/apache/incubator-eventmesh/commit/0e4def2cc9ea25be504f65f9a7f7e860764c9777?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0e4def2) will **decrease** coverage by `0.02%`.
> The diff coverage is `0.00%`.
> :exclamation: Current head bfaa9c4 differs from pull request most recent head 073b5e3. Consider uploading reports for the commit 073b5e3 to get more accurate results
[](https://codecov.io/gh/apache/incubator-eventmesh/pull/479?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## develop #479 +/- ##
=============================================
- Coverage 11.25% 11.23% -0.03%
Complexity 326 326
=============================================
Files 228 228
Lines 10796 10816 +20
Branches 907 907
=============================================
Hits 1215 1215
- Misses 9484 9504 +20
Partials 97 97
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-eventmesh/pull/479?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../eventmesh/common/config/ConfigurationWrapper.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/479/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9jb25maWcvQ29uZmlndXJhdGlvbldyYXBwZXIuamF2YQ==) | `48.38% <0.00%> (ø)` | |
| [...ocol/tcp/client/EventMeshTcpMessageDispatcher.java](https://codecov.io/gh/apache/incubator-eventmesh/pull/479/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2NvcmUvcHJvdG9jb2wvdGNwL2NsaWVudC9FdmVudE1lc2hUY3BNZXNzYWdlRGlzcGF0Y2hlci5qYXZh) | `0.00% <0.00%> (ø)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/479?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-eventmesh/pull/479?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [0e4def2...073b5e3](https://codecov.io/gh/apache/incubator-eventmesh/pull/479?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] xwm1992 commented on a change in pull request #479: [ISSUE #473]fix configuration property get error
Posted by GitBox <gi...@apache.org>.
xwm1992 commented on a change in pull request #479:
URL: https://github.com/apache/incubator-eventmesh/pull/479#discussion_r680627996
##########
File path: eventmesh-common/src/main/java/org/apache/eventmesh/common/config/ConfigurationWrapper.java
##########
@@ -80,7 +80,7 @@ public int getIntProp(String configKey, int defaultValue) {
if (StringUtils.isEmpty(configValue)) {
return defaultValue;
}
- Preconditions.checkState(StringUtils.isNumeric(configKey), String.format("%s error", configKey));
+ Preconditions.checkState(StringUtils.isNumeric(configValue), String.format("%s error", configKey));
Review comment:
I prefer `String.format("key:%s value:%s error", configKey, configValue)` this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org