You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/09/03 20:35:25 UTC
[GitHub] [superset] michael-s-molina opened a new pull request #16587: chore: Merges latest Select changes
michael-s-molina opened a new pull request #16587:
URL: https://github.com/apache/superset/pull/16587
### SUMMARY
Merges latest `Select` changes made in https://github.com/apache/superset/pull/16483, https://github.com/apache/superset/pull/16393, and https://github.com/apache/superset/pull/16510.
### TESTING INSTRUCTIONS
All tests should pass.
### ADDITIONAL INFORMATION
- [ ] Has associated issue:
- [ ] Required feature flags:
- [ ] Changes UI
- [ ] Includes DB Migration (follow approval process in [SIP-59](https://github.com/apache/superset/issues/13351))
- [ ] Migration is atomic, supports rollback & is backwards-compatible
- [ ] Confirm DB migration upgrade and downgrade tested
- [ ] Runtime estimates and downtime expectations provided
- [ ] Introduces new feature or API
- [ ] Removes existing feature or API
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina merged pull request #16587: chore: Merges latest Select changes
Posted by GitBox <gi...@apache.org>.
michael-s-molina merged pull request #16587:
URL: https://github.com/apache/superset/pull/16587
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #16587: chore: Merges latest Select changes
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #16587:
URL: https://github.com/apache/superset/pull/16587#discussion_r702150834
##########
File path: superset-frontend/src/components/Select/Select.tsx
##########
@@ -49,8 +49,12 @@ type PickedSelectProps = Pick<
| 'autoFocus'
| 'disabled'
| 'filterOption'
+ | 'labelInValue'
+ | 'loading'
| 'notFoundContent'
| 'onChange'
+ | 'onClear'
+ | 'onFocus'
Review comment:
@geido I didn't add `defaultValue` assuming that we can use `value`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #16587: chore: Merges latest Select changes
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #16587:
URL: https://github.com/apache/superset/pull/16587#discussion_r702149336
##########
File path: superset-frontend/src/components/Select/Select.tsx
##########
@@ -416,6 +427,7 @@ const Select = ({
allowNewOptions,
initialOptions,
isSingleMode,
+ onChange,
Review comment:
@geido `onChange` was not in the list of dependencies in your original PR. It's a good idea to check that this function is being memoized π
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #16587: chore: Merges latest Select changes
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #16587:
URL: https://github.com/apache/superset/pull/16587#issuecomment-912808451
# [Codecov](https://codecov.io/gh/apache/superset/pull/16587?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#16587](https://codecov.io/gh/apache/superset/pull/16587?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7a406d3) into [master](https://codecov.io/gh/apache/superset/commit/5f8dff1341306abe3e7e7586575991adafa627c6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (5f8dff1) will **increase** coverage by `0.00%`.
> The diff coverage is `84.00%`.
[](https://codecov.io/gh/apache/superset/pull/16587?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #16587 +/- ##
=======================================
Coverage 76.71% 76.71%
=======================================
Files 1002 1002
Lines 53823 53832 +9
Branches 7287 7293 +6
=======================================
+ Hits 41292 41299 +7
- Misses 12291 12293 +2
Partials 240 240
```
| Flag | Coverage Ξ | |
|---|---|---|
| javascript | `70.99% <84.00%> (+<0.01%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/16587?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Ξ | |
|---|---|---|
| [superset-frontend/src/components/Select/Select.tsx](https://codecov.io/gh/apache/superset/pull/16587/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1NlbGVjdC50c3g=) | `72.65% <84.00%> (+0.19%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/16587?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Ξ = absolute <relative> (impact)`, `ΓΈ = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/16587?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [5f8dff1...7a406d3](https://codecov.io/gh/apache/superset/pull/16587?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #16587: chore: Merges latest Select changes
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #16587:
URL: https://github.com/apache/superset/pull/16587#discussion_r702149336
##########
File path: superset-frontend/src/components/Select/Select.tsx
##########
@@ -416,6 +427,7 @@ const Select = ({
allowNewOptions,
initialOptions,
isSingleMode,
+ onChange,
Review comment:
@geido `onChange` was not in the list of dependencies in your original PR. It's a good idea to check that you're passing a memoized function π
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #16587: chore: Merges latest Select changes
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #16587:
URL: https://github.com/apache/superset/pull/16587#discussion_r702149336
##########
File path: superset-frontend/src/components/Select/Select.tsx
##########
@@ -416,6 +427,7 @@ const Select = ({
allowNewOptions,
initialOptions,
isSingleMode,
+ onChange,
Review comment:
@geido onChange was not on the list of dependencies in your original PR. It's a good idea to check that this function is being memoized π
##########
File path: superset-frontend/src/components/Select/Select.tsx
##########
@@ -416,6 +427,7 @@ const Select = ({
allowNewOptions,
initialOptions,
isSingleMode,
+ onChange,
Review comment:
@geido `onChange` was not on the list of dependencies in your original PR. It's a good idea to check that this function is being memoized π
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org