[GitHub] [phoenix] nsgupta1 commented on a change in pull request #1288: PHOENIX-6472 In case of region inconsistency phoenix should stop grac…

[GitBox <gi...@apache.org>]

nsgupta1 commented on a change in pull request #1288:
URL: https://github.com/apache/phoenix/pull/1288#discussion_r692414234



##########
File path: phoenix-core/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java
##########
@@ -666,8 +681,8 @@ public void clearTableRegionCache(byte[] tableName) throws SQLException {
                 do {
                     HRegionLocation regionLocation = connection.getRegionLocation(
                             TableName.valueOf(tableName), currentKey, reload);

Review comment:
       @yanxinyi @dbwong are the locations in the regionLocations object always sorted ? If yes, then only it makes sense to compare if previous endKey is lesser than current endKey otherwise just comparing for equality will give us an answer if it is overlap. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org